FindBugs Results

The following document contains the results of FindBugs.

Summary

Files Errors
25 56

Files

Files Violations
net.sourceforge.addam.Main$ClassPathHacker 1
net.sourceforge.addam.Main 2
net.sourceforge.addam.ddlgen.GenerateTask 4
net.sourceforge.addam.ddlgen.GeneratorSpec 4
net.sourceforge.addam.ddlrun.ServletContainerUpgrader 2
net.sourceforge.addam.impexp.DataCodec$BlobCodec 2
net.sourceforge.addam.impexp.DataCodec$StandardCodec 1
net.sourceforge.addam.impexp.ExportDataTask 1
net.sourceforge.addam.impexp.ImportDataTask 11
net.sourceforge.addam.impexp.Script 1
net.sourceforge.addam.impexp.Tables 1
net.sourceforge.addam.selectexec.SelectExecTask 3
net.sourceforge.addam.util.DatabaseMetaDataUtil 2
net.sourceforge.addam.util.TableUtil 1
net.sourceforge.addam.ddlgen.generic.InsertGenerator 3
net.sourceforge.addam.ddlgen.generic.TableGenerator 2
net.sourceforge.addam.ddlgen.generic.VelocityGenerator 4
net.sourceforge.addam.ddlgen.oracle.DBMSMetadataGenerator 3
net.sourceforge.addam.ddlrun.grammars.OracleGrammar 2
net.sourceforge.addam.ddlrun.runners.DeploymentRunnerFactory 1
net.sourceforge.addam.ddlrun.runners.JDBCStatementRunner 1
net.sourceforge.addam.impexp.csv.CSVParser 1
net.sourceforge.addam.Main$1 1
net.sourceforge.addam.ddlgen.oracle.IndexGenerator$1 1
net.sourceforge.addam.ddlrun.utils.ClassLoaderReader 1

net.sourceforge.addam.Main$ClassPathHacker

Violation Line Priority
DP: net.sourceforge.addam.Main$ClassPathHacker.addFile(String) invokes java.lang.reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block 261 Low

net.sourceforge.addam.Main

Violation Line Priority
Dm: net.sourceforge.addam.Main.getConf(java.util.Map,String) invokes System.exit(...), which shuts down the entire virtual machine 182 Low
NP: Possible null pointer dereference in net.sourceforge.addam.Main.main(String[]) on exception path 171 Low

net.sourceforge.addam.ddlgen.GenerateTask

Violation Line Priority
Dm: Method net.sourceforge.addam.ddlgen.GenerateTask.execute() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 63 Low
Dm: Method net.sourceforge.addam.ddlgen.GenerateTask.execute() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 66 Low
RCN: Redundant nullcheck of value known to be null net.sourceforge.addam.ddlgen.GenerateTask.execute() 104 Normal
OS: net.sourceforge.addam.ddlgen.GenerateTask.execute() may fail to close stream 80 Normal

net.sourceforge.addam.ddlgen.GeneratorSpec

Violation Line Priority
Dm: Method net.sourceforge.addam.ddlgen.GeneratorSpec.getGenerator() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 153 Low
OS: net.sourceforge.addam.ddlgen.GeneratorSpec.setIncludesFile(java.io.File) may fail to close stream 73 Normal
OS: net.sourceforge.addam.ddlgen.GeneratorSpec.setExcludesFile(java.io.File) may fail to close stream 101 Normal
UwF: Field not initialized in constructor: net.sourceforge.addam.ddlgen.GeneratorSpec.type -1 Low

net.sourceforge.addam.ddlrun.ServletContainerUpgrader

Violation Line Priority
RCN: Nullcheck at ServletContainerUpgrader.java:[line 94] of value previously dereferenced at net.sourceforge.addam.ddlrun.ServletContainerUpgrader.contextInitialized(javax.servlet.ServletContextEvent) 94 High
REC: Method net.sourceforge.addam.ddlrun.ServletContainerUpgrader.contextInitialized(javax.servlet.ServletContextEvent) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 114 Low

net.sourceforge.addam.impexp.DataCodec$BlobCodec

Violation Line Priority
RR: net.sourceforge.addam.impexp.DataCodec$BlobCodec.encode(Object) ignores result of java.io.InputStream.read(byte[]) 105 Normal
REC: Method net.sourceforge.addam.impexp.DataCodec$BlobCodec.encode(Object) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 108 Low

net.sourceforge.addam.impexp.DataCodec$StandardCodec

Violation Line Priority
REC: Method net.sourceforge.addam.impexp.DataCodec$StandardCodec.decode(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 171 Low

net.sourceforge.addam.impexp.ExportDataTask

Violation Line Priority
SQL: Method net.sourceforge.addam.impexp.ExportDataTask.exportTable(String,java.sql.Connection) passes a nonconstant String to an execute method on an SQL statement 88 Low

net.sourceforge.addam.impexp.ImportDataTask

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at net.sourceforge.addam.impexp.ImportDataTask.executeScript(Script) 137 Low
SQL: Method net.sourceforge.addam.impexp.ImportDataTask.emptyTable(String) passes a nonconstant String to an execute method on an SQL statement 161 Low
SQL: Method net.sourceforge.addam.impexp.ImportDataTask.emptyTable(String) passes a nonconstant String to an execute method on an SQL statement 162 Low
SQL: A prepared statement is generated from a nonconstant String at net.sourceforge.addam.impexp.ImportDataTask.importTable(String,java.sql.Connection) 192 Normal
SQL: A prepared statement is generated from a nonconstant String at net.sourceforge.addam.impexp.ImportDataTask.importTable(String,java.sql.Connection) 238 Normal
NP: Possible null pointer dereference in net.sourceforge.addam.impexp.ImportDataTask.importTable(String,java.sql.Connection) on exception path 286 Low
NP: Possible null pointer dereference in net.sourceforge.addam.impexp.ImportDataTask.importTable(String,java.sql.Connection) on exception path 287 Low
NP: Possible null pointer dereference in net.sourceforge.addam.impexp.ImportDataTask.importTable(String,java.sql.Connection) on exception path 299 Low
NP: Possible null pointer dereference in net.sourceforge.addam.impexp.ImportDataTask.importTable(String,java.sql.Connection) 219 Normal
ODR: net.sourceforge.addam.impexp.ImportDataTask.executeScript(Script) may fail to close database resource 134 Normal
REC: Method net.sourceforge.addam.impexp.ImportDataTask.importTable(String,java.sql.Connection) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 296 Low

net.sourceforge.addam.impexp.Script

Violation Line Priority
OS: net.sourceforge.addam.impexp.Script.getText() may fail to close stream 95 Normal

net.sourceforge.addam.impexp.Tables

Violation Line Priority
OS: net.sourceforge.addam.impexp.Tables.setFile(java.io.File) may fail to close stream 92 Normal

net.sourceforge.addam.selectexec.SelectExecTask

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at net.sourceforge.addam.selectexec.SelectExecTask.execute() 65 Low
SQL: Method net.sourceforge.addam.selectexec.SelectExecTask.execute() passes a nonconstant String to an execute method on an SQL statement 81 Low
SQL: Method net.sourceforge.addam.selectexec.SelectExecTask.execute() passes a nonconstant String to an execute method on an SQL statement 75 Low

net.sourceforge.addam.util.DatabaseMetaDataUtil

Violation Line Priority
Dm: Method net.sourceforge.addam.util.DatabaseMetaDataUtil.getTables(String,String,java.sql.Connection) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 26 Low
Dm: Method net.sourceforge.addam.util.DatabaseMetaDataUtil.getTables(String,String,java.sql.Connection) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 29 Low

net.sourceforge.addam.util.TableUtil

Violation Line Priority
Dm: Method net.sourceforge.addam.util.TableUtil.getTableName(java.io.File) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 15 Low

net.sourceforge.addam.ddlgen.generic.InsertGenerator

Violation Line Priority
Dm: Method net.sourceforge.addam.ddlgen.generic.InsertGenerator.generate(String,String,String,String,java.sql.Connection,java.sql.DatabaseMetaData,java.io.BufferedWriter) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 40 Low
Dm: Method net.sourceforge.addam.ddlgen.generic.InsertGenerator.generate(String,String,String,String,java.sql.Connection,java.sql.DatabaseMetaData,java.io.BufferedWriter) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 44 Low
SQL: Method net.sourceforge.addam.ddlgen.generic.InsertGenerator.getContext(String,String,String,java.sql.Connection,java.sql.DatabaseMetaData) passes a nonconstant String to an execute method on an SQL statement 59 Low

net.sourceforge.addam.ddlgen.generic.TableGenerator

Violation Line Priority
RCN: Redundant nullcheck of value known to be null net.sourceforge.addam.ddlgen.generic.TableGenerator.getContext(String,String,String,java.sql.Connection,java.sql.DatabaseMetaData) 61 Normal
RCN: Redundant nullcheck of value known to be null net.sourceforge.addam.ddlgen.generic.TableGenerator.getContext(String,String,String,java.sql.Connection,java.sql.DatabaseMetaData) 62 Normal

net.sourceforge.addam.ddlgen.generic.VelocityGenerator

Violation Line Priority
Dm: Method net.sourceforge.addam.ddlgen.generic.VelocityGenerator.getObjects(String,String,net.sourceforge.addam.ddlgen.Filter,java.sql.Connection,java.sql.DatabaseMetaData) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 34 Low
Dm: Method net.sourceforge.addam.ddlgen.generic.VelocityGenerator.getObjects(String,String,net.sourceforge.addam.ddlgen.Filter,java.sql.Connection,java.sql.DatabaseMetaData) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 37 Low
Dm: Method net.sourceforge.addam.ddlgen.generic.VelocityGenerator.generate(String,String,String,String,java.sql.Connection,java.sql.DatabaseMetaData,java.io.BufferedWriter) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 55 Low
Dm: Method net.sourceforge.addam.ddlgen.generic.VelocityGenerator.generate(String,String,String,String,java.sql.Connection,java.sql.DatabaseMetaData,java.io.BufferedWriter) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 58 Low

net.sourceforge.addam.ddlgen.oracle.DBMSMetadataGenerator

Violation Line Priority
Dm: Method net.sourceforge.addam.ddlgen.oracle.DBMSMetadataGenerator.generate(String,String,String,String,String,java.sql.Connection,java.sql.DatabaseMetaData,java.io.BufferedWriter) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 71 Low
Dm: Method net.sourceforge.addam.ddlgen.oracle.DBMSMetadataGenerator.generate(String,String,String,String,String,java.sql.Connection,java.sql.DatabaseMetaData,java.io.BufferedWriter) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 74 Low
OS: net.sourceforge.addam.ddlgen.oracle.DBMSMetadataGenerator.generate(String,String,String,String,String,java.sql.Connection,java.sql.DatabaseMetaData,java.io.BufferedWriter) may fail to close stream 91 Normal

net.sourceforge.addam.ddlrun.grammars.OracleGrammar

Violation Line Priority
Dm: Method net.sourceforge.addam.ddlrun.grammars.OracleGrammar.shouldIgnore(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 36 Low
Dm: Method net.sourceforge.addam.ddlrun.grammars.OracleGrammar.beginsComplexStatement(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 62 Low

net.sourceforge.addam.ddlrun.runners.DeploymentRunnerFactory

Violation Line Priority
DLS: Dead store to runLogger in method net.sourceforge.addam.ddlrun.runners.DeploymentRunnerFactory.getUpgradeRunner(net.sourceforge.addam.ddlrun.utils.ResourceReaderFactory,java.sql.Connection,net.sourceforge.addam.ddlrun.grammars.ScriptGrammar,net.sourceforge.addam.ddlrun.utils.StartFolderRetriever,net.sourceforge.addam.ddlrun.utils.CompletedScriptRetriever) 84 High

net.sourceforge.addam.ddlrun.runners.JDBCStatementRunner

Violation Line Priority
NP: Possible null pointer dereference in net.sourceforge.addam.ddlrun.runners.JDBCStatementRunner.run(String) on exception path 53 Low

net.sourceforge.addam.impexp.csv.CSVParser

Violation Line Priority
Dm: Method net.sourceforge.addam.impexp.csv.CSVParser.getExcelCell(int,int) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 202 Low

net.sourceforge.addam.Main$1

Violation Line Priority
UrF: Unread field: net.sourceforge.addam.Main$1.count -1 Normal

net.sourceforge.addam.ddlgen.oracle.IndexGenerator$1

Violation Line Priority
SIC: The class net.sourceforge.addam.ddlgen.oracle.IndexGenerator$1 could be refactored into a named _static_ inner class -1 Low

net.sourceforge.addam.ddlrun.utils.ClassLoaderReader

Violation Line Priority
UrF: Unread field: net.sourceforge.addam.ddlrun.utils.ClassLoaderReader.resourcePath -1 Normal