Violation | Line |
---|---|
The class 'Main' has a Cyclomatic Complexity of 4 (Highest = 12). - details... | 46 |
Document empty constructor - details... | 57 |
Avoid really long methods. - details... | 60 |
Parameter 'args' is not assigned and could be declared final - details... | 60 |
The method 'main' has a Cyclomatic Complexity of 12. - details... | 60 |
A method should have only one exit point, and that should be the last statement in the method - details... | 66 |
System.out.print is used - details... | 77 |
Avoid printStackTrace(); use a logger call instead. - details... | 78 |
A method should have only one exit point, and that should be the last statement in the method - details... | 79 |
Local variable could be declared final - details... | 82 |
Local variable could be declared final - details... | 83 |
Local variable could be declared final - details... | 84 |
The String literal "password" appears 4 times in this file; the first occurrence is on line 84 - details... | 84 |
Local variable could be declared final - details... | 85 |
Local variable could be declared final - details... | 86 |
Local variable could be declared final - details... | 92 |
Avoid throwing raw exception types - details... | 95 |
Avoid throwing raw exception types - details... | 98 |
Avoid throwing raw exception types - details... | 100 |
Avoid throwing raw exception types - details... | 102 |
System.out.print is used - details... | 111 |
A method should have only one exit point, and that should be the last statement in the method - details... | 112 |
Local variable could be declared final - details... | 119 |
System.out.print is used - details... | 123 |
Local variable could be declared final - details... | 124 |
Avoid throwing raw exception types - details... | 131 |
Local variable could be declared final - details... | 133 |
Local variable could be declared final - details... | 134 |
Avoid throwing raw exception types - details... | 148 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 152 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 152 |
System.out.print is used - details... | 153 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 156 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 156 |
System.out.print is used - details... | 157 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 160 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 160 |
System.out.print is used - details... | 161 |
System.out.print is used - details... | 166 |
Avoid printStackTrace(); use a logger call instead. - details... | 173 |
Parameter 'key' is not assigned and could be declared final - details... | 178 |
Parameter 'map' is not assigned and could be declared final - details... | 178 |
Local variable could be declared final - details... | 179 |
System.out.print is used - details... | 181 |
Parameter 'configFileName' is not assigned and could be declared final - details... | 187 |
Local variable could be declared final - details... | 188 |
Local variable could be declared final - details... | 193 |
Local variable could be declared final - details... | 196 |
Local variable could be declared final - details... | 201 |
System.out.print is used - details... | 204 |
Local variable could be declared final - details... | 205 |
Parameter 'configFileName' is not assigned and could be declared final - details... | 211 |
System.out.print is used - details... | 212 |
System.out.print is used - details... | 213 |
System.out.print is used - details... | 214 |
System.out.print is used - details... | 215 |
System.out.print is used - details... | 216 |
System.out.print is used - details... | 217 |
System.out.print is used - details... | 218 |
System.out.print is used - details... | 219 |
System.out.print is used - details... | 220 |
Avoid variables with short names like i - details... | 225 |
Avoid using if statements without curly braces - details... | 226 |
Avoid using if statements without curly braces - details... | 228 |
Avoid variables with short names like i - details... | 234 |
Avoid using if statements without curly braces - details... | 235 |
Avoid using if statements without curly braces - details... | 240 |
Each class should declare at least one constructor - details... | 245 |
Parameter 'fileName' is not assigned and could be declared final - details... | 247 |
Local variable could be declared final - details... | 258 |
Local variable could be declared final - details... | 260 |
A catch statement should never catch throwable since it includes errors - details... | 263 |
Avoid printStackTrace(); use a logger call instead. - details... | 264 |
Caught exception is rethrown, original stack trace may be lost - details... | 265 |
Violation | Line |
---|---|
Avoid modifiers which are implied by the context - details... | 11 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 37 |
The class 'GenerateTask' has a Cyclomatic Complexity of 4 (Highest = 14). - details... | 37 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 39 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 40 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 41 |
Parameter 'schema' is not assigned and could be declared final - details... | 43 |
Parameter 'catalog' is not assigned and could be declared final - details... | 47 |
Parameter 'spec' is not assigned and could be declared final - details... | 51 |
The method 'execute' has a Cyclomatic Complexity of 14. - details... | 55 |
Local variable could be declared final - details... | 57 |
Local variable could be declared final - details... | 61 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 63 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 63 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 64 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 64 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 66 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 66 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 67 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 67 |
Local variable could be declared final - details... | 70 |
Local variable could be declared final - details... | 71 |
Local variable could be declared final - details... | 74 |
Avoid excessively long variable names like masterScriptWriter - details... | 77 |
Local variable could be declared final - details... | 77 |
Avoid instantiating new objects inside loops - details... | 80 |
Avoid instantiating new objects inside loops - details... | 83 |
Avoid using if statements without curly braces - details... | 91 |
Avoid using if statements without curly braces - details... | 102 |
Avoid using if statements without curly braces - details... | 104 |
Avoid using if statements without curly braces - details... | 105 |
Avoid using if statements without curly braces - details... | 112 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 7 |
Avoid modifiers which are implied by the context - details... | 30 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 31 |
Avoid modifiers which are implied by the context - details... | 43 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 45 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 34 |
Parameter 'type' is not assigned and could be declared final - details... | 36 |
Parameter 'vendor' is not assigned and could be declared final - details... | 40 |
Parameter 'file' is not assigned and could be declared final - details... | 44 |
Avoid reassigning parameters such as 'prefix' - details... | 48 |
Avoid using if statements without curly braces - details... | 49 |
Avoid reassigning parameters such as 'extension' - details... | 53 |
Avoid using if statements without curly braces - details... | 54 |
Parameter 'includes' is not assigned and could be declared final - details... | 58 |
Local variable could be declared final - details... | 59 |
Avoid instantiating new objects inside loops - details... | 61 |
Local variable could be declared final - details... | 61 |
Parameter 'pattern' is not assigned and could be declared final - details... | 67 |
Parameter 'includesFile' is not assigned and could be declared final - details... | 71 |
Local variable could be declared final - details... | 73 |
Avoid instantiating new objects inside loops - details... | 75 |
Local variable could be declared final - details... | 75 |
Caught exception is rethrown, original stack trace may be lost - details... | 80 |
Caught exception is rethrown, original stack trace may be lost - details... | 82 |
Parameter 'excludes' is not assigned and could be declared final - details... | 86 |
Local variable could be declared final - details... | 87 |
Avoid instantiating new objects inside loops - details... | 89 |
Local variable could be declared final - details... | 89 |
Parameter 'pattern' is not assigned and could be declared final - details... | 95 |
Parameter 'excludesFile' is not assigned and could be declared final - details... | 99 |
Local variable could be declared final - details... | 101 |
Local variable could be declared final - details... | 102 |
Avoid instantiating new objects inside loops - details... | 103 |
Local variable could be declared final - details... | 103 |
Caught exception is rethrown, original stack trace may be lost - details... | 108 |
Caught exception is rethrown, original stack trace may be lost - details... | 110 |
Parameter 'dir' is not assigned and could be declared final - details... | 114 |
Parameter 'table' is not assigned and could be declared final - details... | 118 |
Parameter 'table' is not assigned and could be declared final - details... | 122 |
Parameter 'objectName' is not assigned and could be declared final - details... | 126 |
Avoid excessively long variable names like normalizedTableName - details... | 129 |
Local variable could be declared final - details... | 129 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 149 |
Local variable could be declared final - details... | 152 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 153 |
Caught exception is rethrown, original stack trace may be lost - details... | 155 |
Local variable could be declared final - details... | 161 |
Avoid reassigning parameters such as 'tableName' - details... | 171 |
This call to String.startsWith can be rewritten using String.charAt(0) - details... | 174 |
Avoid using if statements without curly braces - details... | 177 |
Parameter 'tableName' is not assigned and could be declared final - details... | 181 |
Parameter 'object' is not assigned and could be declared final - details... | 185 |
This call to String.startsWith can be rewritten using String.charAt(0) - details... | 188 |
Local variable could be declared final - details... | 191 |
Local variable could be declared final - details... | 192 |
Avoid using if statements without curly braces - details... | 193 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 197 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 198 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 199 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 200 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 202 |
Avoid excessively long variable names like masterScriptWriter - details... | 203 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 203 |
Perhaps 'masterScriptWriter' could be replaced by a local variable. - details... | 203 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 204 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 205 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 206 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 207 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 25 |
Parameter 'name' is not assigned and could be declared final - details... | 28 |
Violation | Line |
---|---|
Avoid excessively long variable names like foreignKeyTableName - details... | 32 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 32 |
Private field 'foreignKeyTableName' could be made final; it is only initialized in the declaration or constructor. - details... | 32 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 33 |
Private field 'foreignKeyName' could be made final; it is only initialized in the declaration or constructor. - details... | 33 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 34 |
Private field 'primaryKeyTable' could be made final; it is only initialized in the declaration or constructor. - details... | 34 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 35 |
Private field 'primaryKeyColumns' could be made final; it is only initialized in the declaration or constructor. - details... | 35 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 36 |
Private field 'foreignKeyColumns' could be made final; it is only initialized in the declaration or constructor. - details... | 36 |
Avoid excessively long variable names like foreignKeyTableName - details... | 38 |
It is a good practice to call super() in a constructor - details... | 38 |
Parameter 'primaryKeyColumn' is not assigned and could be declared final - details... | 44 |
Parameter 'foreignKeyColumn' is not assigned and could be declared final - details... | 48 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 21 |
Each class should declare at least one constructor - details... | 37 |
Parameter 'catalog' is not assigned and could be declared final - details... | 39 |
Parameter 'object' is not assigned and could be declared final - details... | 39 |
Parameter 'schema' is not assigned and could be declared final - details... | 39 |
Parameter 'connection' is not assigned and could be declared final - details... | 40 |
Parameter 'metadata' is not assigned and could be declared final - details... | 40 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 41 |
Local variable could be declared final - details... | 42 |
Local variable could be declared final - details... | 45 |
Local variable could be declared final - details... | 48 |
Avoid instantiating new objects inside loops - details... | 50 |
Local variable could be declared final - details... | 50 |
Local variable could be declared final - details... | 56 |
Avoid using if statements without curly braces - details... | 63 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 32 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 33 |
Private field 'rows' could be made final; it is only initialized in the declaration or constructor. - details... | 33 |
Avoid reassigning parameters such as 'catalog' - details... | 35 |
Avoid reassigning parameters such as 'catalog' - details... | 35 |
Avoid reassigning parameters such as 'object' - details... | 35 |
Avoid reassigning parameters such as 'object' - details... | 35 |
Avoid reassigning parameters such as 'schema' - details... | 35 |
Avoid reassigning parameters such as 'schema' - details... | 35 |
Parameter 'connection' is not assigned and could be declared final - details... | 36 |
Parameter 'metadata' is not assigned and could be declared final - details... | 36 |
Parameter 'vendor' is not assigned and could be declared final - details... | 36 |
Parameter 'writer' is not assigned and could be declared final - details... | 36 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 37 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 40 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 40 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 41 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 41 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 42 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 42 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 44 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 44 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 45 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 45 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 46 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 46 |
Parameter 'catalog' is not assigned and could be declared final - details... | 51 |
Parameter 'object' is not assigned and could be declared final - details... | 51 |
Parameter 'schema' is not assigned and could be declared final - details... | 51 |
Parameter 'connection' is not assigned and could be declared final - details... | 52 |
Parameter 'metadata' is not assigned and could be declared final - details... | 52 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 53 |
Local variable could be declared final - details... | 54 |
Avoid printStackTrace(); use a logger call instead. - details... | 67 |
Avoid using if statements without curly braces - details... | 69 |
Avoid using if statements without curly braces - details... | 70 |
Parameter 'resultSet' is not assigned and could be declared final - details... | 75 |
Local variable could be declared final - details... | 76 |
Local variable could be declared final - details... | 77 |
Local variable could be declared final - details... | 78 |
Parameter 'sqlType' is not assigned and could be declared final - details... | 85 |
Parameter 'unformattedString' is not assigned and could be declared final - details... | 85 |
A method should have only one exit point, and that should be the last statement in the method - details... | 87 |
A method should have only one exit point, and that should be the last statement in the method - details... | 89 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 28 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 29 |
Private field 'columns' could be made final; it is only initialized in the declaration or constructor. - details... | 29 |
Parameter 'column' is not assigned and could be declared final - details... | 31 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 30 |
Private field 'name' could be made final; it is only initialized in the declaration or constructor. - details... | 30 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 31 |
Private field 'type' could be made final; it is only initialized in the declaration or constructor. - details... | 31 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 32 |
Private field 'size' could be made final; it is only initialized in the declaration or constructor. - details... | 32 |
Avoid excessively long variable names like includeInPrecision - details... | 33 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 35 |
Private field 'precision' could be made final; it is only initialized in the declaration or constructor. - details... | 35 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 36 |
Private field 'defaultValue' could be made final; it is only initialized in the declaration or constructor. - details... | 36 |
Parameter 'numberOfSpaces' is not assigned and could be declared final - details... | 70 |
Prefer StringBuffer over += for concatenating strings - details... | 73 |
A method should have only one exit point, and that should be the last statement in the method - details... | 80 |
A method should have only one exit point, and that should be the last statement in the method - details... | 82 |
Avoid using if...else statements without curly braces - details... | 84 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 37 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 38 |
Perhaps 'columns' could be replaced by a local variable. - details... | 38 |
Private field 'columns' could be made final; it is only initialized in the declaration or constructor. - details... | 38 |
Avoid excessively long variable names like nonNullableColumns - details... | 39 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 39 |
Private field 'nonNullableColumns' could be made final; it is only initialized in the declaration or constructor. - details... | 39 |
Avoid excessively long variable names like defaultValueColumns - details... | 40 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 40 |
Private field 'defaultValueColumns' could be made final; it is only initialized in the declaration or constructor. - details... | 40 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 41 |
Private field 'columnIndexes' could be made final; it is only initialized in the declaration or constructor. - details... | 41 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 42 |
Private field 'primaryKeys' could be made final; it is only initialized in the declaration or constructor. - details... | 42 |
Parameter 'catalog' is not assigned and could be declared final - details... | 44 |
Parameter 'object' is not assigned and could be declared final - details... | 44 |
Parameter 'schema' is not assigned and could be declared final - details... | 44 |
Parameter 'connection' is not assigned and could be declared final - details... | 45 |
Parameter 'metadata' is not assigned and could be declared final - details... | 45 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 46 |
Local variable could be declared final - details... | 47 |
Local variable could be declared final - details... | 50 |
Local variable could be declared final - details... | 51 |
Avoid using if statements without curly braces - details... | 60 |
Avoid using if statements without curly braces - details... | 61 |
Avoid using if statements without curly braces - details... | 62 |
Parameter 'catalog' is not assigned and could be declared final - details... | 74 |
Parameter 'dbmd' is not assigned and could be declared final - details... | 74 |
Parameter 'schema' is not assigned and could be declared final - details... | 74 |
Parameter 'tableName' is not assigned and could be declared final - details... | 74 |
Ensure that resources like this ResultSet object are closed after use - details... | 75 |
Local variable could be declared final - details... | 75 |
Avoid excessively long variable names like primaryKeyColumnMap - details... | 77 |
Local variable could be declared final - details... | 77 |
Local variable could be declared final - details... | 79 |
Avoid instantiating new objects inside loops - details... | 82 |
Local variable could be declared final - details... | 82 |
Local variable could be declared final - details... | 85 |
Parameter 'catalog' is not assigned and could be declared final - details... | 94 |
Parameter 'dbmd' is not assigned and could be declared final - details... | 94 |
Parameter 'schema' is not assigned and could be declared final - details... | 94 |
Parameter 'tableName' is not assigned and could be declared final - details... | 94 |
Ensure that resources like this ResultSet object are closed after use - details... | 95 |
Local variable could be declared final - details... | 95 |
Local variable could be declared final - details... | 96 |
Local variable could be declared final - details... | 98 |
Avoid instantiating new objects inside loops - details... | 101 |
Local variable could be declared final - details... | 101 |
Local variable could be declared final - details... | 104 |
Parameter 'indexName' is not assigned and could be declared final - details... | 113 |
Local variable could be declared final - details... | 115 |
A method should have only one exit point, and that should be the last statement in the method - details... | 116 |
Avoid using if statements without curly braces - details... | 116 |
Parameter 'columnMetaData' is not assigned and could be declared final - details... | 121 |
Local variable could be declared final - details... | 122 |
Local variable could be declared final - details... | 123 |
Local variable could be declared final - details... | 124 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 29 |
Private field 'indexName' could be made final; it is only initialized in the declaration or constructor. - details... | 29 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 30 |
Private field 'firstColumnName' could be made final; it is only initialized in the declaration or constructor. - details... | 30 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 31 |
Private field 'unique' could be made final; it is only initialized in the declaration or constructor. - details... | 31 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 32 |
Private field 'columns' could be made final; it is only initialized in the declaration or constructor. - details... | 32 |
It is a good practice to call super() in a constructor - details... | 34 |
Parameter 'columnName' is not assigned and could be declared final - details... | 48 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 29 |
Private field 'firstColumnName' could be made final; it is only initialized in the declaration or constructor. - details... | 29 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 30 |
Private field 'primaryKeyName' could be made final; it is only initialized in the declaration or constructor. - details... | 30 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 31 |
Private field 'columns' could be made final; it is only initialized in the declaration or constructor. - details... | 31 |
It is a good practice to call super() in a constructor - details... | 33 |
Parameter 'column' is not assigned and could be declared final - details... | 46 |
Violation | Line |
---|---|
Abstract classes should be named AbstractXXX - details... | 29 |
Each class should declare at least one constructor - details... | 29 |
Avoid reassigning parameters such as 'catalog' - details... | 31 |
Avoid reassigning parameters such as 'catalog' - details... | 31 |
Avoid reassigning parameters such as 'schema' - details... | 31 |
Avoid reassigning parameters such as 'schema' - details... | 31 |
Parameter 'filter' is not assigned and could be declared final - details... | 31 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 32 |
Parameter 'connection' is not assigned and could be declared final - details... | 32 |
Parameter 'metadata' is not assigned and could be declared final - details... | 32 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 34 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 34 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 35 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 35 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 37 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 37 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 38 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 38 |
Ensure that resources like this ResultSet object are closed after use - details... | 40 |
Local variable could be declared final - details... | 40 |
Local variable could be declared final - details... | 41 |
Local variable could be declared final - details... | 43 |
Avoid reassigning parameters such as 'catalog' - details... | 51 |
Avoid reassigning parameters such as 'catalog' - details... | 51 |
Avoid reassigning parameters such as 'schema' - details... | 51 |
Avoid reassigning parameters such as 'schema' - details... | 51 |
Parameter 'object' is not assigned and could be declared final - details... | 51 |
Avoid reassigning parameters such as 'vendor' - details... | 52 |
Parameter 'connection' is not assigned and could be declared final - details... | 52 |
Parameter 'metadata' is not assigned and could be declared final - details... | 52 |
Parameter 'writer' is not assigned and could be declared final - details... | 52 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 53 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 55 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 55 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 56 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 56 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 58 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 58 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 59 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 59 |
Avoid using if statements without curly braces - details... | 61 |
Local variable could be declared final - details... | 62 |
Local variable could be declared final - details... | 63 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 68 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 70 |
Parameter 'metadata' is not assigned and could be declared final - details... | 70 |
Parameter 'vendor' is not assigned and could be declared final - details... | 70 |
Local variable could be declared final - details... | 74 |
Local variable could be declared final - details... | 81 |
Local variable could be declared final - details... | 84 |
Parameter 'vendor' is not assigned and could be declared final - details... | 90 |
Local variable could be declared final - details... | 91 |
Local variable could be declared final - details... | 92 |
String.indexOf(char) is faster than String.indexOf(String) - details... | 92 |
Local variable could be declared final - details... | 93 |
Local variable could be declared final - details... | 94 |
Local variable could be declared final - details... | 95 |
Violation | Line |
---|---|
Abstract classes should be named AbstractXXX - details... | 22 |
Each class should declare at least one constructor - details... | 22 |
Parameter 'catalog' is not assigned and could be declared final - details... | 30 |
Parameter 'filter' is not assigned and could be declared final - details... | 30 |
Parameter 'schema' is not assigned and could be declared final - details... | 30 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 31 |
Parameter 'connection' is not assigned and could be declared final - details... | 31 |
Parameter 'metadata' is not assigned and could be declared final - details... | 31 |
Parameter 'catalog' is not assigned and could be declared final - details... | 35 |
Parameter 'filter' is not assigned and could be declared final - details... | 35 |
Parameter 'objectType' is not assigned and could be declared final - details... | 35 |
Parameter 'schema' is not assigned and could be declared final - details... | 35 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 36 |
Parameter 'args' is not assigned and could be declared final - details... | 36 |
Parameter 'connection' is not assigned and could be declared final - details... | 36 |
Parameter 'metadata' is not assigned and could be declared final - details... | 36 |
Parameter 'objectsSQL' is not assigned and could be declared final - details... | 36 |
Local variable could be declared final - details... | 38 |
Local variable could be declared final - details... | 49 |
Avoid using if statements without curly braces - details... | 55 |
Avoid using if statements without curly braces - details... | 56 |
Parameter 'catalog' is not assigned and could be declared final - details... | 61 |
Parameter 'object' is not assigned and could be declared final - details... | 61 |
Parameter 'schema' is not assigned and could be declared final - details... | 61 |
Parameter 'connection' is not assigned and could be declared final - details... | 62 |
Parameter 'metadata' is not assigned and could be declared final - details... | 62 |
Parameter 'vendor' is not assigned and could be declared final - details... | 62 |
Parameter 'writer' is not assigned and could be declared final - details... | 62 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 63 |
Avoid reassigning parameters such as 'object' - details... | 67 |
Avoid reassigning parameters such as 'object' - details... | 67 |
Avoid reassigning parameters such as 'schema' - details... | 67 |
Avoid reassigning parameters such as 'schema' - details... | 67 |
Parameter 'catalog' is not assigned and could be declared final - details... | 67 |
Parameter 'objectType' is not assigned and could be declared final - details... | 67 |
Parameter 'connection' is not assigned and could be declared final - details... | 68 |
Parameter 'metadata' is not assigned and could be declared final - details... | 68 |
Parameter 'vendor' is not assigned and could be declared final - details... | 68 |
Parameter 'writer' is not assigned and could be declared final - details... | 68 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 69 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 71 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 71 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 72 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 72 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 74 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 74 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 75 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 75 |
Local variable could be declared final - details... | 89 |
Local variable could be declared final - details... | 90 |
Avoid instantiating new objects inside loops - details... | 91 |
Local variable could be declared final - details... | 91 |
Avoid using if statements without curly braces - details... | 100 |
Avoid using if statements without curly braces - details... | 101 |
Parameter 'line' is not assigned and could be declared final - details... | 105 |
Parameter 'writer' is not assigned and could be declared final - details... | 105 |
Parameter 'connection' is not assigned and could be declared final - details... | 111 |
Parameter 'param' is not assigned and could be declared final - details... | 111 |
Parameter 'value' is not assigned and could be declared final - details... | 111 |
Avoid using if statements without curly braces - details... | 119 |
Parameter 'connection' is not assigned and could be declared final - details... | 123 |
Avoid using if statements without curly braces - details... | 129 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 12 |
Parameter 'catalog' is not assigned and could be declared final - details... | 18 |
Parameter 'object' is not assigned and could be declared final - details... | 18 |
Parameter 'schema' is not assigned and could be declared final - details... | 18 |
Parameter 'connection' is not assigned and could be declared final - details... | 19 |
Parameter 'metadata' is not assigned and could be declared final - details... | 19 |
Parameter 'vendor' is not assigned and could be declared final - details... | 19 |
Parameter 'writer' is not assigned and could be declared final - details... | 19 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 20 |
Parameter 'line' is not assigned and could be declared final - details... | 27 |
Parameter 'writer' is not assigned and could be declared final - details... | 27 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 36 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 8 |
Avoid unused imports such as 'java.io.BufferedReader' - details... | 9 |
Avoid unused imports such as 'java.io.Reader' - details... | 10 |
Avoid unused imports such as 'java.util.List' - details... | 12 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 13 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.Generator' - details... | 15 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 16 |
Each class should declare at least one constructor - details... | 18 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 14 |
Parameter 'catalog' is not assigned and could be declared final - details... | 26 |
Parameter 'filter' is not assigned and could be declared final - details... | 26 |
Parameter 'schema' is not assigned and could be declared final - details... | 26 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 27 |
Parameter 'connection' is not assigned and could be declared final - details... | 27 |
Parameter 'metadata' is not assigned and could be declared final - details... | 27 |
Parameter 'catalog' is not assigned and could be declared final - details... | 31 |
Parameter 'object' is not assigned and could be declared final - details... | 31 |
Parameter 'schema' is not assigned and could be declared final - details... | 31 |
Parameter 'connection' is not assigned and could be declared final - details... | 32 |
Parameter 'metadata' is not assigned and could be declared final - details... | 32 |
Parameter 'vendor' is not assigned and could be declared final - details... | 32 |
Parameter 'writer' is not assigned and could be declared final - details... | 32 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 33 |
Local variable could be declared final - details... | 34 |
Local variable could be declared final - details... | 40 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 8 |
Avoid unused imports such as 'java.io.BufferedReader' - details... | 9 |
Avoid unused imports such as 'java.io.Reader' - details... | 10 |
Avoid unused imports such as 'java.util.List' - details... | 13 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 14 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.Generator' - details... | 16 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 17 |
Each class should declare at least one constructor - details... | 19 |
Parameter 'catalog' is not assigned and could be declared final - details... | 25 |
Parameter 'object' is not assigned and could be declared final - details... | 25 |
Parameter 'schema' is not assigned and could be declared final - details... | 25 |
Parameter 'connection' is not assigned and could be declared final - details... | 26 |
Parameter 'metadata' is not assigned and could be declared final - details... | 26 |
Parameter 'vendor' is not assigned and could be declared final - details... | 26 |
Parameter 'writer' is not assigned and could be declared final - details... | 26 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 27 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 8 |
Avoid unused imports such as 'java.io.BufferedReader' - details... | 9 |
Avoid unused imports such as 'java.io.Reader' - details... | 10 |
Avoid unused imports such as 'java.util.List' - details... | 12 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 13 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.Generator' - details... | 15 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 16 |
Each class should declare at least one constructor - details... | 18 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 8 |
Avoid unused imports such as 'java.io.BufferedReader' - details... | 9 |
Avoid unused imports such as 'java.io.Reader' - details... | 10 |
Avoid unused imports such as 'java.util.List' - details... | 12 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 13 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.Generator' - details... | 15 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 16 |
Each class should declare at least one constructor - details... | 18 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 8 |
Avoid unused imports such as 'java.io.BufferedReader' - details... | 9 |
Avoid unused imports such as 'java.io.Reader' - details... | 10 |
Avoid unused imports such as 'java.util.List' - details... | 13 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 14 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.Generator' - details... | 16 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 17 |
Each class should declare at least one constructor - details... | 19 |
Parameter 'catalog' is not assigned and could be declared final - details... | 25 |
Parameter 'object' is not assigned and could be declared final - details... | 25 |
Parameter 'schema' is not assigned and could be declared final - details... | 25 |
Parameter 'connection' is not assigned and could be declared final - details... | 26 |
Parameter 'metadata' is not assigned and could be declared final - details... | 26 |
Parameter 'vendor' is not assigned and could be declared final - details... | 26 |
Parameter 'writer' is not assigned and could be declared final - details... | 26 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 27 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 8 |
Avoid unused imports such as 'java.io.BufferedReader' - details... | 9 |
Avoid unused imports such as 'java.io.Reader' - details... | 10 |
Avoid unused imports such as 'java.util.List' - details... | 12 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 13 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.Generator' - details... | 15 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 16 |
Each class should declare at least one constructor - details... | 18 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 8 |
Avoid unused imports such as 'java.io.BufferedReader' - details... | 9 |
Avoid unused imports such as 'java.io.Reader' - details... | 10 |
Avoid unused imports such as 'java.util.List' - details... | 13 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 14 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.Generator' - details... | 16 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 17 |
Each class should declare at least one constructor - details... | 19 |
Parameter 'catalog' is not assigned and could be declared final - details... | 25 |
Parameter 'object' is not assigned and could be declared final - details... | 25 |
Parameter 'schema' is not assigned and could be declared final - details... | 25 |
Parameter 'connection' is not assigned and could be declared final - details... | 26 |
Parameter 'metadata' is not assigned and could be declared final - details... | 26 |
Parameter 'vendor' is not assigned and could be declared final - details... | 26 |
Parameter 'writer' is not assigned and could be declared final - details... | 26 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 27 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Writer' - details... | 8 |
Avoid unused imports such as 'java.io.BufferedReader' - details... | 9 |
Avoid unused imports such as 'java.io.Reader' - details... | 10 |
Avoid unused imports such as 'java.util.List' - details... | 13 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 14 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.Generator' - details... | 16 |
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 17 |
Each class should declare at least one constructor - details... | 19 |
Parameter 'catalog' is not assigned and could be declared final - details... | 25 |
Parameter 'object' is not assigned and could be declared final - details... | 25 |
Parameter 'schema' is not assigned and could be declared final - details... | 25 |
Parameter 'connection' is not assigned and could be declared final - details... | 26 |
Parameter 'metadata' is not assigned and could be declared final - details... | 26 |
Parameter 'vendor' is not assigned and could be declared final - details... | 26 |
Parameter 'writer' is not assigned and could be declared final - details... | 26 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 27 |
Violation | Line |
---|---|
Avoid unnecessary constructors - the compiler will generate these for you - details... | 40 |
Document empty constructor - details... | 40 |
It is a good practice to call super() in a constructor - details... | 40 |
Parameter 'script' is not assigned and could be declared final - details... | 43 |
Ensure that resources like this Connection object are closed after use - details... | 48 |
Local variable could be declared final - details... | 48 |
Local variable could be declared final - details... | 49 |
Local variable could be declared final - details... | 50 |
Local variable could be declared final - details... | 55 |
System.out.print is used - details... | 59 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 66 |
Parameter 'script' is not assigned and could be declared final - details... | 66 |
Parameter 'time' is not assigned and could be declared final - details... | 66 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 70 |
Parameter 'group' is not assigned and could be declared final - details... | 70 |
Parameter 'time' is not assigned and could be declared final - details... | 70 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 74 |
Avoid variables with short names like e - details... | 74 |
Parameter 'e' is not assigned and could be declared final - details... | 74 |
Parameter 'group' is not assigned and could be declared final - details... | 74 |
Parameter 'script' is not assigned and could be declared final - details... | 74 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 78 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 55 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 57 |
Use explicit scoping instead of the default package private level - details... | 57 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 58 |
Use explicit scoping instead of the default package private level - details... | 58 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 59 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 60 |
Local variable could be declared final - details... | 71 |
Local variable could be declared final - details... | 77 |
A method should have only one exit point, and that should be the last statement in the method - details... | 79 |
Local variable could be declared final - details... | 89 |
Local variable could be declared final - details... | 93 |
Local variable could be declared final - details... | 94 |
Local variable could be declared final - details... | 96 |
Avoid throwing raw exception types - details... | 98 |
Local variable could be declared final - details... | 100 |
Local variable could be declared final - details... | 117 |
Avoid empty catch blocks - details... | 119 |
Avoid throwing raw exception types - details... | 123 |
Avoid empty catch blocks - details... | 128 |
Avoid empty catch blocks - details... | 135 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 142 |
Parameter 'script' is not assigned and could be declared final - details... | 142 |
Parameter 'time' is not assigned and could be declared final - details... | 142 |
Local variable could be declared final - details... | 143 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 148 |
Parameter 'group' is not assigned and could be declared final - details... | 148 |
Parameter 'time' is not assigned and could be declared final - details... | 148 |
Local variable could be declared final - details... | 149 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 153 |
Avoid variables with short names like e - details... | 153 |
Parameter 'e' is not assigned and could be declared final - details... | 153 |
Parameter 'group' is not assigned and could be declared final - details... | 153 |
Parameter 'script' is not assigned and could be declared final - details... | 153 |
Local variable could be declared final - details... | 154 |
Avoid throwing raw exception types - details... | 156 |
Avoid variables with short names like e - details... | 159 |
Parameter 'e' is not assigned and could be declared final - details... | 159 |
Parameter 'message' is not assigned and could be declared final - details... | 159 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 160 |
Avoid variables with short names like t - details... | 160 |
Local variable could be declared final - details... | 160 |
Avoid if (x != y) ..; else ..; - details... | 161 |
Avoid if (x != y) ..; else ..; - details... | 167 |
Parameter 'sCtx' is not assigned and could be declared final - details... | 182 |
Local variable could be declared final - details... | 184 |
Local variable could be declared final - details... | 189 |
Local variable could be declared final - details... | 190 |
Document empty method - details... | 203 |
Parameter 'event' is not assigned and could be declared final - details... | 203 |
Each class should declare at least one constructor - details... | 207 |
Parameter 'format' is not assigned and could be declared final - details... | 208 |
Parameter 'properties' is not assigned and could be declared final - details... | 208 |
Avoid variables with short names like p - details... | 209 |
Local variable could be declared final - details... | 209 |
Avoid variables with short names like m - details... | 210 |
Local variable could be declared final - details... | 210 |
Local variable could be declared final - details... | 211 |
Local variable could be declared final - details... | 212 |
Local variable could be declared final - details... | 214 |
Local variable could be declared final - details... | 215 |
Local variable could be declared final - details... | 216 |
Local variable could be declared final - details... | 217 |
Parameter 'properties' is not assigned and could be declared final - details... | 225 |
Parameter 'variable' is not assigned and could be declared final - details... | 225 |
Position literals first in String comparisons - details... | 228 |
Violation | Line |
---|---|
Avoid unnecessary constructors - the compiler will generate these for you - details... | 44 |
Document empty constructor - details... | 44 |
It is a good practice to call super() in a constructor - details... | 44 |
Parameter 'script' is not assigned and could be declared final - details... | 47 |
Parameter 'version' is not assigned and could be declared final - details... | 51 |
Ensure that resources like this Connection object are closed after use - details... | 56 |
Local variable could be declared final - details... | 56 |
Local variable could be declared final - details... | 57 |
Local variable could be declared final - details... | 58 |
Local variable could be declared final - details... | 63 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 76 |
Parameter 'script' is not assigned and could be declared final - details... | 76 |
Parameter 'time' is not assigned and could be declared final - details... | 76 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 80 |
Parameter 'group' is not assigned and could be declared final - details... | 80 |
Parameter 'time' is not assigned and could be declared final - details... | 80 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 84 |
Avoid variables with short names like e - details... | 84 |
Parameter 'e' is not assigned and could be declared final - details... | 84 |
Parameter 'group' is not assigned and could be declared final - details... | 84 |
Parameter 'script' is not assigned and could be declared final - details... | 84 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 88 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 89 |
Violation | Line |
---|---|
Avoid excessively long variable names like GET_COMPLETED_SCRIPTS_SQL - details... | 40 |
Local variable could be declared final - details... | 47 |
Local variable could be declared final - details... | 49 |
Ensure that resources like this ResultSet object are closed after use - details... | 50 |
Local variable could be declared final - details... | 50 |
Avoid throwing raw exception types - details... | 55 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 60 |
Violation | Line |
---|---|
Avoid excessively long variable names like undefineVersionStatement - details... | 44 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 44 |
Perhaps 'undefineVersionStatement' could be replaced by a local variable. - details... | 44 |
Avoid excessively long variable names like insertScriptLogStatement - details... | 45 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 45 |
Perhaps 'insertScriptLogStatement' could be replaced by a local variable. - details... | 45 |
Avoid excessively long variable names like updateVersionStatement - details... | 46 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 46 |
Perhaps 'updateVersionStatement' could be replaced by a local variable. - details... | 46 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 47 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 48 |
Avoid if (x != y) ..; else ..; - details... | 55 |
Parameter 'script' is not assigned and could be declared final - details... | 58 |
Parameter 'time' is not assigned and could be declared final - details... | 58 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 75 |
Parameter 'group' is not assigned and could be declared final - details... | 75 |
Parameter 'time' is not assigned and could be declared final - details... | 75 |
Avoid variables with short names like e - details... | 86 |
Parameter 'e' is not assigned and could be declared final - details... | 86 |
Parameter 'group' is not assigned and could be declared final - details... | 86 |
Parameter 'script' is not assigned and could be declared final - details... | 86 |
System.out.print is used - details... | 87 |
Violation | Line |
---|---|
Avoid excessively long variable names like GET_START_FOLDER_SQL - details... | 39 |
Ensure that resources like this ResultSet object are closed after use - details... | 50 |
Local variable could be declared final - details... | 50 |
Avoid throwing raw exception types - details... | 57 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 62 |
Violation | Line |
---|---|
Parameter 'collection' is not assigned and could be declared final - details... | 40 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 45 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 46 |
It is somewhat confusing to have a field name with the same name as a method - details... | 46 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 59 |
Avoid using if statements without curly braces - details... | 67 |
Local variable could be declared final - details... | 68 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 72 |
Parameter 'item' is not assigned and could be declared final - details... | 81 |
Local variable could be declared final - details... | 82 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 86 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 87 |
Violation | Line |
---|---|
Avoid modifiers which are implied by the context - details... | 35 |
Avoid modifiers which are implied by the context - details... | 40 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 34 |
Parameter 'collection' is not assigned and could be declared final - details... | 36 |
Local variable could be declared final - details... | 37 |
Local variable could be declared final - details... | 38 |
Local variable could be declared final - details... | 39 |
Violation | Line |
---|---|
Parameter 'collection' is not assigned and could be declared final - details... | 40 |
Local variable could be declared final - details... | 41 |
Local variable could be declared final - details... | 44 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 53 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 30 |
Avoid excessively long variable names like COMPLEX_STATEMENT_TERMINATOR - details... | 31 |
Avoid excessively long variable names like SIMPLE_STATEMENT_TERMINATOR - details... | 32 |
Avoid reassigning parameters such as 'line' - details... | 35 |
A method should have only one exit point, and that should be the last statement in the method - details... | 37 |
Avoid using if statements without curly braces - details... | 37 |
A method should have only one exit point, and that should be the last statement in the method - details... | 38 |
Avoid using if statements without curly braces - details... | 38 |
A method should have only one exit point, and that should be the last statement in the method - details... | 39 |
Avoid using if statements without curly braces - details... | 39 |
A method should have only one exit point, and that should be the last statement in the method - details... | 40 |
Avoid using if statements without curly braces - details... | 40 |
A method should have only one exit point, and that should be the last statement in the method - details... | 41 |
Avoid using if statements without curly braces - details... | 41 |
Avoid reassigning parameters such as 'line' - details... | 45 |
A method should have only one exit point, and that should be the last statement in the method - details... | 47 |
Avoid using if statements without curly braces - details... | 47 |
A method should have only one exit point, and that should be the last statement in the method - details... | 48 |
Avoid using if statements without curly braces - details... | 48 |
Avoid reassigning parameters such as 'line' - details... | 52 |
Avoid reassigning parameters such as 'line' - details... | 52 |
Avoid variables with short names like i - details... | 54 |
Local variable could be declared final - details... | 54 |
Avoid reassigning parameters such as 'line' - details... | 61 |
A method should have only one exit point, and that should be the last statement in the method - details... | 63 |
Avoid using if statements without curly braces - details... | 63 |
A method should have only one exit point, and that should be the last statement in the method - details... | 64 |
Avoid using if statements without curly braces - details... | 64 |
A method should have only one exit point, and that should be the last statement in the method - details... | 67 |
Avoid reassigning parameters such as 'line' - details... | 73 |
A method should have only one exit point, and that should be the last statement in the method - details... | 75 |
Avoid using if statements without curly braces - details... | 75 |
Avoid reassigning parameters such as 'line' - details... | 79 |
Avoid variables with short names like i - details... | 80 |
Local variable could be declared final - details... | 80 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.Map' - details... | 24 |
Avoid unused imports such as 'java.util.Set' - details... | 25 |
Avoid modifiers which are implied by the context - details... | 35 |
Avoid modifiers which are implied by the context - details... | 37 |
Avoid modifiers which are implied by the context - details... | 38 |
Avoid modifiers which are implied by the context - details... | 40 |
Avoid modifiers which are implied by the context - details... | 41 |
Avoid modifiers which are implied by the context - details... | 42 |
Avoid modifiers which are implied by the context - details... | 44 |
Violation | Line |
---|---|
In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. - details... | 50 |
Avoid throwing raw exception types - details... | 52 |
Avoid throwing raw exception types - details... | 56 |
Avoid variables with short names like in - details... | 61 |
Avoid throwing raw exception types - details... | 66 |
Avoid throwing raw exception types - details... | 74 |
Parameter 'connection' is not assigned and could be declared final - details... | 84 |
Avoid throwing raw exception types - details... | 90 |
Local variable could be declared final - details... | 96 |
Avoid throwing raw exception types - details... | 101 |
Avoid throwing raw exception types - details... | 103 |
Avoid throwing raw exception types - details... | 105 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 119 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.IOException' - details... | 25 |
Avoid unused constructor parameters such as 'version' - details... | 54 |
Parameter 'logger' is not assigned and could be declared final - details... | 71 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 79 |
Parameter 'resource' is not assigned and could be declared final - details... | 79 |
Local variable could be declared final - details... | 80 |
Local variable could be declared final - details... | 81 |
Local variable could be declared final - details... | 82 |
Local variable could be declared final - details... | 83 |
Avoid instantiating new objects inside loops - details... | 84 |
Local variable could be declared final - details... | 84 |
Local variable could be declared final - details... | 85 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 92 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 93 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 94 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 95 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 96 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 43 |
Parameter 'readerFactory' is not assigned and could be declared final - details... | 49 |
Parameter 'connection' is not assigned and could be declared final - details... | 50 |
Parameter 'grammar' is not assigned and could be declared final - details... | 51 |
Local variable could be declared final - details... | 52 |
Local variable could be declared final - details... | 53 |
Local variable could be declared final - details... | 54 |
Local variable could be declared final - details... | 57 |
Parameter 'readerFactory' is not assigned and could be declared final - details... | 75 |
Parameter 'connection' is not assigned and could be declared final - details... | 76 |
Parameter 'grammar' is not assigned and could be declared final - details... | 77 |
Avoid excessively long variable names like startFolderRetriever - details... | 78 |
Parameter 'startFolderRetriever' is not assigned and could be declared final - details... | 78 |
Avoid excessively long variable names like completedScriptRetriever - details... | 79 |
Parameter 'completedScriptRetriever' is not assigned and could be declared final - details... | 79 |
Local variable could be declared final - details... | 81 |
Local variable could be declared final - details... | 82 |
Local variable could be declared final - details... | 83 |
Avoid unused local variables such as 'runLogger' - details... | 84 |
Local variable could be declared final - details... | 84 |
Local variable could be declared final - details... | 87 |
Local variable could be declared final - details... | 88 |
Violation | Line |
---|---|
The class 'JDBCScriptRunner' has a Cyclomatic Complexity of 5 (Highest = 11). - details... | 34 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 51 |
Parameter 'resource' is not assigned and could be declared final - details... | 51 |
The method 'run' has a Cyclomatic Complexity of 11. - details... | 51 |
Local variable could be declared final - details... | 52 |
Local variable could be declared final - details... | 53 |
Avoid appending characters as strings in StringBuffer.append - details... | 60 |
Local variable could be declared final - details... | 65 |
Avoid appending characters as strings in StringBuffer.append - details... | 74 |
Local variable could be declared final - details... | 78 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 113 |
Parameter 'statement' is not assigned and could be declared final - details... | 113 |
System.out.print is used - details... | 119 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 124 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 125 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 126 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.regex.Pattern' - details... | 27 |
Avoid unused imports such as 'java.util.regex.Matcher' - details... | 28 |
Avoid unused imports such as 'java.util.ArrayList' - details... | 29 |
Avoid unused imports such as 'java.util.Date' - details... | 30 |
Avoid unused imports such as 'java.text.MessageFormat' - details... | 31 |
Parameter 'resource' is not assigned and could be declared final - details... | 47 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 58 |
Violation | Line |
---|---|
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 32 |
Avoid modifiers which are implied by the context - details... | 32 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.IOException' - details... | 25 |
Parameter 'logger' is not assigned and could be declared final - details... | 59 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 63 |
Parameter 'group' is not assigned and could be declared final - details... | 63 |
Parameter 'time' is not assigned and could be declared final - details... | 63 |
Local variable could be declared final - details... | 64 |
Local variable could be declared final - details... | 65 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 70 |
Parameter 'script' is not assigned and could be declared final - details... | 70 |
Parameter 'time' is not assigned and could be declared final - details... | 70 |
Local variable could be declared final - details... | 71 |
Local variable could be declared final - details... | 72 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 77 |
Avoid variables with short names like e - details... | 77 |
Parameter 'e' is not assigned and could be declared final - details... | 77 |
Parameter 'group' is not assigned and could be declared final - details... | 77 |
Parameter 'script' is not assigned and could be declared final - details... | 77 |
Local variable could be declared final - details... | 78 |
Local variable could be declared final - details... | 79 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 88 |
Parameter 'group' is not assigned and could be declared final - details... | 88 |
Local variable could be declared final - details... | 89 |
Local variable could be declared final - details... | 90 |
Local variable could be declared final - details... | 94 |
Local variable could be declared final - details... | 95 |
Local variable could be declared final - details... | 96 |
Avoid variables with short names like i - details... | 97 |
Local variable could be declared final - details... | 97 |
String.indexOf(char) is faster than String.indexOf(String) - details... | 97 |
Local variable could be declared final - details... | 99 |
Local variable could be declared final - details... | 100 |
Avoid instantiating new objects inside loops - details... | 102 |
Avoid throwing raw exception types - details... | 102 |
Avoid variables with short names like e - details... | 102 |
Local variable could be declared final - details... | 102 |
Avoid instantiating new objects inside loops - details... | 108 |
Local variable could be declared final - details... | 108 |
Avoid instantiating new objects inside loops - details... | 110 |
Local variable could be declared final - details... | 110 |
Avoid printStackTrace(); use a logger call instead. - details... | 114 |
Avoid instantiating new objects inside loops - details... | 121 |
Avoid throwing raw exception types - details... | 121 |
Avoid variables with short names like e - details... | 121 |
Local variable could be declared final - details... | 121 |
Local variable could be declared final - details... | 126 |
Parameter 'resource' is not assigned and could be declared final - details... | 131 |
Local variable could be declared final - details... | 132 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 133 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 136 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 137 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 138 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 139 |
Violation | Line |
---|---|
In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. - details... | 59 |
Local variable could be declared final - details... | 59 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 69 |
Perhaps 'reader' could be replaced by a local variable. - details... | 69 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 70 |
Use explicit scoping instead of the default package private level - details... | 70 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 71 |
Use explicit scoping instead of the default package private level - details... | 71 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 72 |
Use explicit scoping instead of the default package private level - details... | 72 |
Violation | Line |
---|---|
Parameter 'resource' is not assigned and could be declared final - details... | 56 |
Parameter 'path' is not assigned and could be declared final - details... | 60 |
Parameter 'resource' is not assigned and could be declared final - details... | 60 |
Prefer StringBuffer over += for concatenating strings - details... | 70 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 76 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 27 |
Private field 'resourceFile' could be made final; it is only initialized in the declaration or constructor. - details... | 27 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 28 |
Private field 'readerFactory' could be made final; it is only initialized in the declaration or constructor. - details... | 28 |
Local variable could be declared final - details... | 36 |
Local variable could be declared final - details... | 37 |
Violation | Line |
---|---|
Caught exception is rethrown, original stack trace may be lost - details... | 50 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 57 |
Perhaps 'reader' could be replaced by a local variable. - details... | 57 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 58 |
Use explicit scoping instead of the default package private level - details... | 58 |
Violation | Line |
---|---|
Parameter 'resource' is not assigned and could be declared final - details... | 57 |
Parameter 'path' is not assigned and could be declared final - details... | 61 |
Parameter 'resource' is not assigned and could be declared final - details... | 61 |
Local variable could be declared final - details... | 62 |
Local variable could be declared final - details... | 63 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 67 |
Avoid unused private fields such as 'SEPARATOR' - details... | 68 |
Violation | Line |
---|---|
Avoid modifiers which are implied by the context - details... | 33 |
Violation | Line |
---|---|
Avoid modifiers which are implied by the context - details... | 33 |
Avoid modifiers which are implied by the context - details... | 35 |
Violation | Line |
---|---|
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 31 |
Avoid modifiers which are implied by the context - details... | 31 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 33 |
Avoid modifiers which are implied by the context - details... | 33 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 35 |
Avoid modifiers which are implied by the context - details... | 35 |
Avoid variables with short names like e - details... | 35 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.sql.SQLException' - details... | 29 |
Abstract classes should be named AbstractXXX - details... | 39 |
Each class should declare at least one constructor - details... | 39 |
Avoid variables with short names like o - details... | 41 |
Avoid variables with short names like s - details... | 43 |
Use explicit scoping instead of the default package private level - details... | 45 |
Avoid reassigning parameters such as 'className' - details... | 47 |
Position literals first in String comparisons - details... | 52 |
Position literals first in String comparisons - details... | 55 |
A method should have only one exit point, and that should be the last statement in the method - details... | 56 |
Position literals first in String comparisons - details... | 57 |
A method should have only one exit point, and that should be the last statement in the method - details... | 58 |
Position literals first in String comparisons - details... | 59 |
A method should have only one exit point, and that should be the last statement in the method - details... | 60 |
Avoid empty catch blocks - details... | 74 |
Each class should declare at least one constructor - details... | 94 |
Avoid variables with short names like o - details... | 96 |
Parameter 'o' is not assigned and could be declared final - details... | 96 |
Avoid variables with short names like b - details... | 97 |
Local variable could be declared final - details... | 97 |
Local variable could be declared final - details... | 103 |
Avoid variables with short names like s - details... | 104 |
Local variable could be declared final - details... | 104 |
Local variable could be declared final - details... | 106 |
Avoid variables with short names like s - details... | 114 |
Parameter 's' is not assigned and could be declared final - details... | 114 |
Local variable could be declared final - details... | 115 |
Consider simply returning the value vs storing it in local variable 'decodedBytes' - details... | 116 |
Each class should declare at least one constructor - details... | 121 |
Avoid variables with short names like o - details... | 123 |
Parameter 'o' is not assigned and could be declared final - details... | 123 |
Local variable could be declared final - details... | 124 |
Avoid variables with short names like s - details... | 128 |
Parameter 's' is not assigned and could be declared final - details... | 128 |
Local variable could be declared final - details... | 129 |
Consider simply returning the value vs storing it in local variable 'decodedBytes' - details... | 130 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 137 |
Use explicit scoping instead of the default package private level - details... | 137 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 138 |
Use explicit scoping instead of the default package private level - details... | 138 |
It is a good practice to call super() in a constructor - details... | 140 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 142 |
It is a good practice to call super() in a constructor - details... | 145 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 147 |
Avoid variables with short names like o - details... | 150 |
Parameter 'o' is not assigned and could be declared final - details... | 150 |
Avoid variables with short names like s - details... | 154 |
Parameter 's' is not assigned and could be declared final - details... | 154 |
Local variable could be declared final - details... | 159 |
Avoid if (x != y) ..; else ..; - details... | 161 |
Avoid if (x != y) ..; else ..; - details... | 164 |
Avoid printStackTrace(); use a logger call instead. - details... | 172 |
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.Iterator' - details... | 38 |
Each class should declare at least one constructor - details... | 41 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 42 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 43 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 44 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 45 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 46 |
Avoid using if statements without curly braces - details... | 62 |
Avoid empty catch blocks - details... | 65 |
Parameter 'connection' is not assigned and could be declared final - details... | 78 |
Parameter 'tableName' is not assigned and could be declared final - details... | 78 |
Local variable could be declared final - details... | 79 |
Local variable could be declared final - details... | 85 |
Ensure that resources like this Statement object are closed after use - details... | 87 |
Local variable could be declared final - details... | 87 |
Avoid variables with short names like rs - details... | 88 |
Ensure that resources like this ResultSet object are closed after use - details... | 88 |
Local variable could be declared final - details... | 88 |
Local variable could be declared final - details... | 89 |
Local variable could be declared final - details... | 90 |
Local variable could be declared final - details... | 102 |
Local variable could be declared final - details... | 103 |
Position literals first in String comparisons - details... | 105 |
Position literals first in String comparisons - details... | 107 |
Avoid variables with short names like o - details... | 113 |
Local variable could be declared final - details... | 113 |
Avoid printStackTrace(); use a logger call instead. - details... | 122 |
Parameter 'tableFile' is not assigned and could be declared final - details... | 141 |
Local variable could be declared final - details... | 142 |
Parameter 'tableFile' is not assigned and could be declared final - details... | 152 |
Local variable could be declared final - details... | 153 |
Parameter 'pattern' is not assigned and could be declared final - details... | 161 |
Local variable could be declared final - details... | 162 |
Parameter 'pattern' is not assigned and could be declared final - details... | 170 |
Local variable could be declared final - details... | 171 |
Parameter 'names' is not assigned and could be declared final - details... | 179 |
Local variable could be declared final - details... | 180 |
Parameter 'names' is not assigned and could be declared final - details... | 188 |
Local variable could be declared final - details... | 189 |
Parameter 'tables' is not assigned and could be declared final - details... | 197 |
Parameter 'tables' is not assigned and could be declared final - details... | 204 |
Parameter 'tableDir' is not assigned and could be declared final - details... | 211 |
Parameter 'schema' is not assigned and could be declared final - details... | 215 |
Parameter 'catalog' is not assigned and could be declared final - details... | 219 |
Avoid using if statements without curly braces - details... | 238 |
Avoid empty catch blocks - details... | 241 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 33 |
The class 'ImportDataTask' has a Cyclomatic Complexity of 3 (Highest = 19). - details... | 33 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 34 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 35 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 36 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 37 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 38 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 39 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 40 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 41 |
Parameter 'tableDir' is not assigned and could be declared final - details... | 46 |
Parameter 'truncateFirst' is not assigned and could be declared final - details... | 54 |
Parameter 'deleteFirst' is not assigned and could be declared final - details... | 62 |
Parameter 'script' is not assigned and could be declared final - details... | 69 |
Avoid using if statements without curly braces - details... | 70 |
Parameter 'script' is not assigned and could be declared final - details... | 77 |
Avoid using if statements without curly braces - details... | 78 |
Parameter 'batchSize' is not assigned and could be declared final - details... | 82 |
Avoid using if statements without curly braces - details... | 83 |
Local variable could be declared final - details... | 101 |
Avoid using if statements without curly braces - details... | 104 |
Local variable could be declared final - details... | 108 |
Avoid empty catch blocks - details... | 116 |
Parameter 'script' is not assigned and could be declared final - details... | 126 |
Ensure that resources like this Connection object are closed after use - details... | 128 |
Local variable could be declared final - details... | 128 |
Local variable could be declared final - details... | 130 |
System.out.print is used - details... | 135 |
System.out.print is used - details... | 138 |
Local variable could be declared final - details... | 140 |
System.out.print is used - details... | 141 |
Avoid using if statements without curly braces - details... | 143 |
Avoid printStackTrace(); use a logger call instead. - details... | 148 |
Parameter 'tableName' is not assigned and could be declared final - details... | 153 |
Ensure that resources like this Connection object are closed after use - details... | 157 |
Local variable could be declared final - details... | 157 |
Avoid using if statements without curly braces - details... | 161 |
Avoid using if statements without curly braces - details... | 162 |
Avoid using if statements without curly braces - details... | 165 |
Avoid printStackTrace(); use a logger call instead. - details... | 168 |
Avoid really long methods. - details... | 180 |
Parameter 'connection' is not assigned and could be declared final - details... | 180 |
Parameter 'tableName' is not assigned and could be declared final - details... | 180 |
The method 'importTable' has a Cyclomatic Complexity of 19. - details... | 180 |
Local variable could be declared final - details... | 181 |
Avoid variables with short names like rs - details... | 194 |
Ensure that resources like this ResultSet object are closed after use - details... | 194 |
Local variable could be declared final - details... | 194 |
Local variable could be declared final - details... | 195 |
Local variable could be declared final - details... | 196 |
Local variable could be declared final - details... | 213 |
Local variable could be declared final - details... | 216 |
Local variable could be declared final - details... | 217 |
Local variable could be declared final - details... | 220 |
Avoid appending characters as strings in StringBuffer.append - details... | 227 |
Avoid appending characters as strings in StringBuffer.append - details... | 228 |
Avoid appending characters as strings in StringBuffer.append - details... | 231 |
Local variable could be declared final - details... | 247 |
Avoid variables with short names like o - details... | 252 |
Local variable could be declared final - details... | 252 |
Local variable could be declared final - details... | 256 |
Avoid instantiating new objects inside loops - details... | 257 |
Local variable could be declared final - details... | 257 |
Avoid printStackTrace(); use a logger call instead. - details... | 304 |
Parameter 'tableFile' is not assigned and could be declared final - details... | 322 |
Local variable could be declared final - details... | 323 |
Parameter 'tableFile' is not assigned and could be declared final - details... | 333 |
Local variable could be declared final - details... | 334 |
Parameter 'pattern' is not assigned and could be declared final - details... | 342 |
Local variable could be declared final - details... | 343 |
Parameter 'pattern' is not assigned and could be declared final - details... | 351 |
Local variable could be declared final - details... | 352 |
Parameter 'names' is not assigned and could be declared final - details... | 360 |
Local variable could be declared final - details... | 361 |
Parameter 'names' is not assigned and could be declared final - details... | 369 |
Local variable could be declared final - details... | 370 |
Local variable could be declared final - details... | 381 |
Local variable could be declared final - details... | 383 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 40 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 42 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 43 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 44 |
Parameter 'separator' is not assigned and could be declared final - details... | 52 |
Parameter 'aFile' is not assigned and could be declared final - details... | 61 |
Parameter 'text' is not assigned and could be declared final - details... | 70 |
Local variable could be declared final - details... | 83 |
Local variable could be declared final - details... | 84 |
Local variable could be declared final - details... | 93 |
Local variable could be declared final - details... | 95 |
Local variable could be declared final - details... | 96 |
Violation | Line |
---|---|
Avoid unused imports such as 'net.sourceforge.addam.util.TableUtil' - details... | 24 |
Each class should declare at least one constructor - details... | 44 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 46 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 47 |
Parameter 'name' is not assigned and could be declared final - details... | 49 |
Avoid if (x != y) ..; else ..; - details... | 50 |
A method should have only one exit point, and that should be the last statement in the method - details... | 51 |
Parameter 'tableNames' is not assigned and could be declared final - details... | 63 |
Parameter 'pattern' is not assigned and could be declared final - details... | 77 |
Parameter 'file' is not assigned and could be declared final - details... | 89 |
Local variable could be declared final - details... | 92 |
Caught exception is rethrown, original stack trace may be lost - details... | 100 |
Parameter 'allTableNames' is not assigned and could be declared final - details... | 110 |
Parameter 'excludes' is not assigned and could be declared final - details... | 110 |
Parameter 'includes' is not assigned and could be declared final - details... | 110 |
Local variable could be declared final - details... | 111 |
Avoid using if statements without curly braces - details... | 117 |
Local variable could be declared final - details... | 123 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 45 |
It is somewhat confusing to have a field name with the same name as a method - details... | 45 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 46 |
It is somewhat confusing to have a field name with the same name as a method - details... | 46 |
Violation | Line |
---|---|
The class 'CSVParser' has a Cyclomatic Complexity of 3 (Highest = 16). - details... | 36 |
Avoid variables with short names like in - details... | 38 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 38 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 39 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 40 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 41 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 42 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 43 |
Avoid variables with short names like in - details... | 50 |
Local variable could be declared final - details... | 70 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 71 |
A method should have only one exit point, and that should be the last statement in the method - details... | 76 |
The method 'readField' has a Cyclomatic Complexity of 16. - details... | 86 |
Avoid excessively long variable names like currentValueQuoted - details... | 94 |
Local variable could be declared final - details... | 95 |
Avoid variables with short names like c - details... | 100 |
Avoid unnecessary comparisons in boolean expressions - details... | 106 |
Deeply nested if..then statements are hard to read - details... | 106 |
Local variable could be declared final - details... | 114 |
Local variable could be declared final - details... | 130 |
Local variable could be declared final - details... | 147 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 154 |
Parameter 'col' is not assigned and could be declared final - details... | 193 |
Parameter 'row' is not assigned and could be declared final - details... | 193 |
Local variable could be declared final - details... | 196 |
Local variable could be declared final - details... | 198 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 32 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 33 |
Parameter 'strings' is not assigned and could be declared final - details... | 49 |
Local variable could be declared final - details... | 50 |
Local variable could be declared final - details... | 52 |
Local variable could be declared final - details... | 53 |
Local variable could be declared final - details... | 54 |
This call to String.startsWith can be rewritten using String.charAt(0) - details... | 57 |
Avoid using if statements without curly braces - details... | 59 |
Avoid appending characters as strings in StringBuffer.append - details... | 60 |
Avoid using if statements without curly braces - details... | 60 |
Avoid appending characters as strings in StringBuffer.append - details... | 62 |
Avoid using if statements without curly braces - details... | 62 |
Avoid appending characters as strings in StringBuffer.append - details... | 64 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 38 |
Avoid variables with short names like in - details... | 40 |
Local variable could be declared final - details... | 52 |
Local variable could be declared final - details... | 53 |
Local variable could be declared final - details... | 54 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 37 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 39 |
Private field 'text' could be made final; it is only initialized in the declaration or constructor. - details... | 39 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 40 |
Parameter 'size' is not assigned and could be declared final - details... | 47 |
Parameter 'text' is not assigned and could be declared final - details... | 56 |
Ensure that resources like this Connection object are closed after use - details... | 62 |
Local variable could be declared final - details... | 62 |
Local variable could be declared final - details... | 63 |
Local variable could be declared final - details... | 65 |
Ensure that resources like this ResultSet object are closed after use - details... | 66 |
Local variable could be declared final - details... | 66 |
Ensure that resources like this Statement object are closed after use - details... | 70 |
Local variable could be declared final - details... | 70 |
Avoid variables with short names like i - details... | 71 |
Local variable could be declared final - details... | 72 |
Local variable could be declared final - details... | 73 |
Avoid printStackTrace(); use a logger call instead. - details... | 84 |
Violation | Line |
---|---|
Avoid unused imports such as 'net.sourceforge.addam.ddlgen.GeneratorSpec' - details... | 11 |
Each class should declare at least one constructor - details... | 20 |
Avoid reassigning parameters such as 'catalog' - details... | 22 |
Avoid reassigning parameters such as 'catalog' - details... | 22 |
Avoid reassigning parameters such as 'schema' - details... | 22 |
Avoid reassigning parameters such as 'schema' - details... | 22 |
Parameter 'connection' is not assigned and could be declared final - details... | 22 |
Local variable could be declared final - details... | 24 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 26 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 26 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 27 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 27 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 29 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 29 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 30 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 30 |
Ensure that resources like this ResultSet object are closed after use - details... | 32 |
Local variable could be declared final - details... | 32 |
Local variable could be declared final - details... | 33 |
Local variable could be declared final - details... | 35 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. - details... | 41 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 12 |
Parameter 'file' is not assigned and could be declared final - details... | 13 |
Local variable could be declared final - details... | 14 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale - details... | 15 |
A method should have only one exit point, and that should be the last statement in the method - details... | 16 |
Parameter 'tableName' is not assigned and could be declared final - details... | 22 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. - details... | 25 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 26 |
No need to import a type that's in the same package - details... | 27 |
No need to import a type that's in the same package - details... | 28 |
Each class should declare at least one constructor - details... | 44 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 45 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 46 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 47 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 49 |
Local variable could be declared final - details... | 53 |
The String literal "krishna" appears 6 times in this file; the first occurrence is on line 58 - details... | 58 |
Local variable could be declared final - details... | 61 |
The String literal ".sql" appears 8 times in this file; the first occurrence is on line 63 - details... | 63 |
Local variable could be declared final - details... | 68 |
Local variable could be declared final - details... | 69 |
Local variable could be declared final - details... | 76 |
Local variable could be declared final - details... | 82 |
Local variable could be declared final - details... | 91 |
Avoid printStackTrace(); use a logger call instead. - details... | 98 |
Local variable could be declared final - details... | 104 |
Local variable could be declared final - details... | 105 |
Local variable could be declared final - details... | 112 |
Local variable could be declared final - details... | 118 |
Local variable could be declared final - details... | 127 |
Local variable could be declared final - details... | 130 |
Avoid printStackTrace(); use a logger call instead. - details... | 137 |
Avoid really long methods. - details... | 142 |
Parameter 'data' is not assigned and could be declared final - details... | 142 |
Local variable could be declared final - details... | 143 |
Local variable could be declared final - details... | 147 |
Local variable could be declared final - details... | 151 |
Local variable could be declared final - details... | 155 |
Local variable could be declared final - details... | 159 |
Local variable could be declared final - details... | 163 |
Local variable could be declared final - details... | 167 |
Local variable could be declared final - details... | 171 |
Local variable could be declared final - details... | 175 |
Local variable could be declared final - details... | 179 |
Local variable could be declared final - details... | 183 |
Local variable could be declared final - details... | 187 |
Local variable could be declared final - details... | 191 |
Local variable could be declared final - details... | 195 |
Local variable could be declared final - details... | 199 |
Local variable could be declared final - details... | 203 |
Local variable could be declared final - details... | 207 |
Local variable could be declared final - details... | 211 |
Local variable could be declared final - details... | 215 |
Local variable could be declared final - details... | 219 |
Local variable could be declared final - details... | 223 |
Local variable could be declared final - details... | 227 |
Local variable could be declared final - details... | 231 |
Local variable could be declared final - details... | 235 |
Local variable could be declared final - details... | 239 |
Local variable could be declared final - details... | 243 |
Local variable could be declared final - details... | 247 |
Local variable could be declared final - details... | 251 |
Avoid excessively long variable names like mockDatabaseMetaData - details... | 259 |
Local variable could be declared final - details... | 259 |
Local variable could be declared final - details... | 260 |
Local variable could be declared final - details... | 268 |
JUnit assertions should include a message - details... | 274 |
JUnit assertions should include a message - details... | 275 |
JUnit assertions should include a message - details... | 276 |
JUnit assertions should include a message - details... | 277 |
Each class should declare at least one constructor - details... | 283 |
Avoid excessively long variable names like numberOfTimesGenerateTableDDLWasCalled - details... | 284 |
Avoid unused private fields such as 'numberOfTimesGenerateTableDDLWasCalled' - details... | 284 |
Private field 'numberOfTimesGenerateTableDDLWasCalled' could be made final; it is only initialized in the declaration or constructor. - details... | 284 |
Avoid excessively long variable names like numberOfTimesAddToForeignDDLWasCalled - details... | 285 |
Avoid unused private fields such as 'numberOfTimesAddToForeignDDLWasCalled' - details... | 285 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 285 |
Perhaps 'numberOfTimesAddToForeignDDLWasCalled' could be replaced by a local variable. - details... | 285 |
Avoid excessively long variable names like generateForeignKeyFileCalled - details... | 286 |
Avoid unused private fields such as 'generateForeignKeyFileCalled' - details... | 286 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 286 |
Perhaps 'generateForeignKeyFileCalled' could be replaced by a local variable. - details... | 286 |
Avoid excessively long variable names like generateTableFileSpecCalled - details... | 287 |
Avoid unused private fields such as 'generateTableFileSpecCalled' - details... | 287 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 287 |
Perhaps 'generateTableFileSpecCalled' could be replaced by a local variable. - details... | 287 |
Parameter 'dbmd' is not assigned and could be declared final - details... | 297 |
Parameter 'tablesResultSet' is not assigned and could be declared final - details... | 297 |
Parameter 'connection' is not assigned and could be declared final - details... | 301 |
Parameter 'generatorSpec' is not assigned and could be declared final - details... | 301 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 21 |
Each class should declare at least one constructor - details... | 28 |
Local variable could be declared final - details... | 31 |
The String literal "foo" appears 4 times in this file; the first occurrence is on line 33 - details... | 33 |
The String literal "baz" appears 4 times in this file; the first occurrence is on line 34 - details... | 34 |
JUnit assertions should include a message - details... | 35 |
The String literal "Bar" appears 4 times in this file; the first occurrence is on line 35 - details... | 35 |
Local variable could be declared final - details... | 39 |
JUnit assertions should include a message - details... | 43 |
JUnit assertions should include a message - details... | 47 |
JUnit assertions should include a message - details... | 51 |
JUnit assertions should include a message - details... | 55 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 25 |
No need to import a type that's in the same package - details... | 26 |
Each class should declare at least one constructor - details... | 37 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 39 |
Local variable could be declared final - details... | 41 |
The String literal "PKCOLUMN_NAME1 " appears 4 times in this file; the first occurrence is on line 41 - details... | 41 |
The String literal "PKTABLE_NAME1 " appears 5 times in this file; the first occurrence is on line 41 - details... | 41 |
The String literal "FKCOLUMN_NAME1 " appears 4 times in this file; the first occurrence is on line 42 - details... | 42 |
The String literal "FKTABLE_NAME1 " appears 5 times in this file; the first occurrence is on line 42 - details... | 42 |
The String literal "FK_NAME1 " appears 5 times in this file; the first occurrence is on line 43 - details... | 43 |
Local variable could be declared final - details... | 44 |
The String literal "PKCOLUMN_NAME2 " appears 4 times in this file; the first occurrence is on line 44 - details... | 44 |
The String literal "FKCOLUMN_NAME2 " appears 4 times in this file; the first occurrence is on line 45 - details... | 45 |
Local variable could be declared final - details... | 47 |
Local variable could be declared final - details... | 54 |
Local variable could be declared final - details... | 56 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 76 |
Local variable could be declared final - details... | 77 |
Local variable could be declared final - details... | 78 |
Local variable could be declared final - details... | 81 |
Local variable could be declared final - details... | 87 |
Local variable could be declared final - details... | 89 |
Local variable could be declared final - details... | 90 |
Local variable could be declared final - details... | 91 |
Local variable could be declared final - details... | 94 |
JUnit assertions should include a message - details... | 95 |
JUnit assertions should include a message - details... | 96 |
JUnit assertions should include a message - details... | 97 |
JUnit assertions should include a message - details... | 98 |
JUnit assertions should include a message - details... | 99 |
JUnit assertions should include a message - details... | 100 |
JUnit assertions should include a message - details... | 101 |
JUnit assertions should include a message - details... | 102 |
JUnit assertions should include a message - details... | 103 |
Parameter 'fkColName' is not assigned and could be declared final - details... | 107 |
Parameter 'fkName' is not assigned and could be declared final - details... | 107 |
Parameter 'fkTabName' is not assigned and could be declared final - details... | 107 |
Parameter 'foreignKeys' is not assigned and could be declared final - details... | 107 |
Parameter 'pkColName' is not assigned and could be declared final - details... | 107 |
Parameter 'pkTabName' is not assigned and could be declared final - details... | 107 |
JUnit assertions should include a message - details... | 115 |
Parameter 'fkColName' is not assigned and could be declared final - details... | 118 |
Parameter 'fkName' is not assigned and could be declared final - details... | 118 |
Parameter 'fkTabName' is not assigned and could be declared final - details... | 118 |
Parameter 'foreignKey' is not assigned and could be declared final - details... | 118 |
Parameter 'pkColName' is not assigned and could be declared final - details... | 118 |
Parameter 'pkTabName' is not assigned and could be declared final - details... | 118 |
Position literals first in String comparisons - details... | 119 |
Position literals first in String comparisons - details... | 122 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 27 |
Each class should declare at least one constructor - details... | 40 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 42 |
Local variable could be declared final - details... | 43 |
Local variable could be declared final - details... | 44 |
Local variable could be declared final - details... | 45 |
Local variable could be declared final - details... | 46 |
JUnit assertions should include a message - details... | 47 |
JUnit assertions should include a message - details... | 48 |
JUnit assertions should include a message - details... | 49 |
Local variable could be declared final - details... | 56 |
JUnit assertions should include a message - details... | 58 |
JUnit assertions should include a message - details... | 61 |
JUnit assertions should include a message - details... | 64 |
Local variable could be declared final - details... | 70 |
Avoid excessively long variable names like mockDatabaseMetaData - details... | 71 |
Local variable could be declared final - details... | 71 |
Local variable could be declared final - details... | 72 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 3 |
Each class should declare at least one constructor - details... | 10 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 11 |
The String literal "defaultValue" appears 11 times in this file; the first occurrence is on line 14 - details... | 14 |
The String literal "name" appears 11 times in this file; the first occurrence is on line 14 - details... | 14 |
The String literal "precision" appears 11 times in this file; the first occurrence is on line 14 - details... | 14 |
The String literal "size" appears 11 times in this file; the first occurrence is on line 14 - details... | 14 |
JUnit assertions should include a message - details... | 15 |
JUnit assertions should include a message - details... | 20 |
JUnit assertions should include a message - details... | 23 |
JUnit assertions should include a message - details... | 26 |
JUnit assertions should include a message - details... | 29 |
JUnit assertions should include a message - details... | 32 |
JUnit assertions should include a message - details... | 35 |
JUnit assertions should include a message - details... | 38 |
JUnit assertions should include a message - details... | 41 |
JUnit assertions should include a message - details... | 44 |
JUnit assertions should include a message - details... | 47 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 7 |
No need to import a type that's in the same package - details... | 8 |
No need to import a type that's in the same package - details... | 9 |
Each class should declare at least one constructor - details... | 20 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 21 |
The String literal "COLUMN_NAME1 " appears 6 times in this file; the first occurrence is on line 21 - details... | 21 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 22 |
Perhaps 'columnDetails2' could be replaced by a local variable. - details... | 22 |
The String literal "COLUMN_NAME2 " appears 7 times in this file; the first occurrence is on line 22 - details... | 22 |
The String literal "TABLE_CAT2 " appears 7 times in this file; the first occurrence is on line 22 - details... | 22 |
The String literal "TABLE_NAME2 " appears 7 times in this file; the first occurrence is on line 22 - details... | 22 |
The String literal "TABLE_SCHEM2 " appears 7 times in this file; the first occurrence is on line 22 - details... | 22 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 24 |
Local variable could be declared final - details... | 25 |
Local variable could be declared final - details... | 28 |
Local variable could be declared final - details... | 33 |
Local variable could be declared final - details... | 34 |
Local variable could be declared final - details... | 35 |
Avoid excessively long variable names like defaultValueColumns - details... | 36 |
Local variable could be declared final - details... | 36 |
Avoid excessively long variable names like nonNullableColumns - details... | 37 |
Local variable could be declared final - details... | 37 |
JUnit assertions should include a message - details... | 43 |
JUnit assertions should include a message - details... | 44 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 50 |
Local variable could be declared final - details... | 51 |
Local variable could be declared final - details... | 53 |
Avoid excessively long variable names like mockResultSetForIndexInfo - details... | 56 |
Local variable could be declared final - details... | 56 |
Local variable could be declared final - details... | 57 |
Local variable could be declared final - details... | 58 |
Local variable could be declared final - details... | 59 |
The String literal "COLUMN_NAME3 " appears 5 times in this file; the first occurrence is on line 59 - details... | 59 |
Local variable could be declared final - details... | 60 |
The String literal "PK_NAME2 " appears 7 times in this file; the first occurrence is on line 60 - details... | 60 |
Local variable could be declared final - details... | 61 |
Avoid excessively long variable names like mockResultSetForPrimaryKeyInfo - details... | 69 |
Local variable could be declared final - details... | 69 |
Local variable could be declared final - details... | 70 |
The String literal "KEY_SEQ2 " appears 4 times in this file; the first occurrence is on line 70 - details... | 70 |
Local variable could be declared final - details... | 71 |
Local variable could be declared final - details... | 78 |
Local variable could be declared final - details... | 79 |
Local variable could be declared final - details... | 80 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 90 |
Local variable could be declared final - details... | 91 |
Local variable could be declared final - details... | 93 |
Avoid excessively long variable names like mockResultSetForPrimaryKeyInfo - details... | 96 |
Local variable could be declared final - details... | 96 |
Local variable could be declared final - details... | 97 |
Local variable could be declared final - details... | 98 |
Local variable could be declared final - details... | 99 |
Local variable could be declared final - details... | 107 |
Local variable could be declared final - details... | 108 |
Local variable could be declared final - details... | 109 |
Parameter 'columnList' is not assigned and could be declared final - details... | 120 |
Parameter 'columnName' is not assigned and could be declared final - details... | 120 |
Parameter 'extraColumn' is not assigned and could be declared final - details... | 120 |
Parameter 'indexName' is not assigned and could be declared final - details... | 120 |
Local variable could be declared final - details... | 123 |
JUnit assertions should include a message - details... | 132 |
Parameter 'columnList' is not assigned and could be declared final - details... | 135 |
Parameter 'columnName' is not assigned and could be declared final - details... | 135 |
Parameter 'extraColumn' is not assigned and could be declared final - details... | 135 |
Parameter 'primaryKeyName' is not assigned and could be declared final - details... | 135 |
Local variable could be declared final - details... | 138 |
JUnit assertions should include a message - details... | 147 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 3 |
Each class should declare at least one constructor - details... | 10 |
JUnit assertions should include a message - details... | 12 |
JUnit assertions should include a message - details... | 13 |
Violation | Line |
---|---|
Each class should declare at least one constructor - details... | 33 |
JUnit tests should include assert() or fail() - details... | 35 |
Avoid variables with short names like p - details... | 36 |
Local variable could be declared final - details... | 36 |
Avoid variables with short names like m - details... | 37 |
Local variable could be declared final - details... | 37 |
Local variable could be declared final - details... | 38 |
Local variable could be declared final - details... | 39 |
Local variable could be declared final - details... | 41 |
Local variable could be declared final - details... | 42 |
Local variable could be declared final - details... | 43 |
Local variable could be declared final - details... | 44 |
System.out.print is used - details... | 49 |
Parameter 'variable' is not assigned and could be declared final - details... | 52 |
Position literals first in String comparisons - details... | 55 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 15 |
Each class should declare at least one constructor - details... | 17 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 19 |
Private field 'itemsToRemove' could be made final; it is only initialized in the declaration or constructor. - details... | 19 |
The String literal "script1.sql" appears 4 times in this file; the first occurrence is on line 20 - details... | 20 |
Local variable could be declared final - details... | 25 |
Local variable could be declared final - details... | 26 |
Local variable could be declared final - details... | 30 |
JUnit assertions should include a message - details... | 31 |
Local variable could be declared final - details... | 35 |
Local variable could be declared final - details... | 36 |
Local variable could be declared final - details... | 42 |
JUnit assertions should include a message - details... | 43 |
Local variable could be declared final - details... | 47 |
Local variable could be declared final - details... | 48 |
The String literal "script3.sql" appears 4 times in this file; the first occurrence is on line 56 - details... | 56 |
The String literal "script4.sql" appears 7 times in this file; the first occurrence is on line 58 - details... | 58 |
The String literal "script5.sql" appears 7 times in this file; the first occurrence is on line 59 - details... | 59 |
Local variable could be declared final - details... | 65 |
JUnit assertions should include a message - details... | 66 |
JUnit assertions should include a message - details... | 67 |
JUnit assertions should include a message - details... | 68 |
JUnit assertions should include a message - details... | 69 |
Local variable could be declared final - details... | 73 |
Local variable could be declared final - details... | 74 |
Local variable could be declared final - details... | 91 |
JUnit assertions should include a message - details... | 92 |
JUnit assertions should include a message - details... | 93 |
JUnit assertions should include a message - details... | 94 |
JUnit assertions should include a message - details... | 95 |
JUnit assertions should include a message - details... | 96 |
JUnit assertions should include a message - details... | 97 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 15 |
Each class should declare at least one constructor - details... | 17 |
Local variable could be declared final - details... | 20 |
Local variable could be declared final - details... | 21 |
Local variable could be declared final - details... | 26 |
JUnit assertions should include a message - details... | 27 |
Local variable could be declared final - details... | 31 |
Local variable could be declared final - details... | 32 |
Local variable could be declared final - details... | 38 |
JUnit assertions should include a message - details... | 39 |
JUnit assertions should include a message - details... | 40 |
Local variable could be declared final - details... | 44 |
Local variable could be declared final - details... | 45 |
Local variable could be declared final - details... | 56 |
JUnit assertions should include a message - details... | 57 |
JUnit assertions should include a message - details... | 58 |
JUnit assertions should include a message - details... | 59 |
JUnit assertions should include a message - details... | 60 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 15 |
Each class should declare at least one constructor - details... | 17 |
Local variable could be declared final - details... | 20 |
The String literal "start" appears 4 times in this file; the first occurrence is on line 20 - details... | 20 |
Local variable could be declared final - details... | 21 |
Local variable could be declared final - details... | 26 |
JUnit assertions should include a message - details... | 27 |
Local variable could be declared final - details... | 31 |
Local variable could be declared final - details... | 32 |
Local variable could be declared final - details... | 38 |
JUnit assertions should include a message - details... | 39 |
JUnit assertions should include a message - details... | 40 |
Local variable could be declared final - details... | 44 |
Local variable could be declared final - details... | 45 |
Local variable could be declared final - details... | 56 |
JUnit assertions should include a message - details... | 57 |
JUnit assertions should include a message - details... | 58 |
JUnit assertions should include a message - details... | 59 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 25 |
Each class should declare at least one constructor - details... | 27 |
Local variable could be declared final - details... | 30 |
Local variable could be declared final - details... | 31 |
JUnit assertions should include a message - details... | 32 |
Local variable could be declared final - details... | 36 |
Local variable could be declared final - details... | 37 |
JUnit assertions should include a message - details... | 38 |
Local variable could be declared final - details... | 42 |
Local variable could be declared final - details... | 44 |
Local variable could be declared final - details... | 45 |
JUnit assertions should include a message - details... | 46 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 20 |
Each class should declare at least one constructor - details... | 24 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 26 |
Local variable could be declared final - details... | 27 |
The String literal "upgrade.drv" appears 4 times in this file; the first occurrence is on line 28 - details... | 28 |
Local variable could be declared final - details... | 32 |
Local variable could be declared final - details... | 33 |
Local variable could be declared final - details... | 34 |
Local variable could be declared final - details... | 35 |
Local variable could be declared final - details... | 36 |
Local variable could be declared final - details... | 37 |
Local variable could be declared final - details... | 39 |
Local variable could be declared final - details... | 42 |
JUnit assertions should include a message - details... | 43 |
JUnit assertions should include a message - details... | 44 |
JUnit assertions should include a message - details... | 45 |
JUnit assertions should include a message - details... | 46 |
JUnit assertions should include a message - details... | 47 |
JUnit assertions should include a message - details... | 48 |
JUnit assertions should include a message - details... | 49 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 52 |
Local variable could be declared final - details... | 53 |
Local variable could be declared final - details... | 58 |
Local variable could be declared final - details... | 59 |
Local variable could be declared final - details... | 60 |
Local variable could be declared final - details... | 63 |
Local variable could be declared final - details... | 64 |
Local variable could be declared final - details... | 65 |
Local variable could be declared final - details... | 66 |
Local variable could be declared final - details... | 68 |
Local variable could be declared final - details... | 71 |
JUnit assertions should include a message - details... | 72 |
JUnit assertions should include a message - details... | 73 |
JUnit assertions should include a message - details... | 74 |
JUnit assertions should include a message - details... | 75 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 16 |
No need to import a type that's in the same package - details... | 17 |
Each class should declare at least one constructor - details... | 20 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 22 |
Local variable could be declared final - details... | 23 |
The String literal "-- comment line then blank\n" appears 9 times in this file; the first occurrence is on line 24 - details... | 24 |
The String literal "script1.sql" appears 18 times in this file; the first occurrence is on line 24 - details... | 24 |
Local variable could be declared final - details... | 32 |
Local variable could be declared final - details... | 33 |
Local variable could be declared final - details... | 34 |
JUnit assertions should include a message - details... | 36 |
The String literal "select * from foo" appears 7 times in this file; the first occurrence is on line 36 - details... | 36 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 39 |
Local variable could be declared final - details... | 40 |
The String literal "select * from foo;\n" appears 5 times in this file; the first occurrence is on line 43 - details... | 43 |
Local variable could be declared final - details... | 48 |
Local variable could be declared final - details... | 49 |
Local variable could be declared final - details... | 50 |
JUnit assertions should include a message - details... | 52 |
JUnit assertions should include a message - details... | 53 |
JUnit assertions should include a message - details... | 54 |
JUnit assertions should include a message - details... | 55 |
JUnit assertions should include a message - details... | 56 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 59 |
Local variable could be declared final - details... | 60 |
The String literal "BEGIN something\n" appears 9 times in this file; the first occurrence is on line 63 - details... | 63 |
The String literal "some more stuff\n" appears 9 times in this file; the first occurrence is on line 64 - details... | 64 |
The String literal "END;\n" appears 9 times in this file; the first occurrence is on line 65 - details... | 65 |
Local variable could be declared final - details... | 67 |
Local variable could be declared final - details... | 68 |
Local variable could be declared final - details... | 69 |
JUnit assertions should include a message - details... | 71 |
JUnit assertions should include a message - details... | 72 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 75 |
Local variable could be declared final - details... | 76 |
The String literal "v_cache_size\n" appears 8 times in this file; the first occurrence is on line 80 - details... | 80 |
Local variable could be declared final - details... | 85 |
Local variable could be declared final - details... | 86 |
Local variable could be declared final - details... | 87 |
JUnit assertions should include a message - details... | 89 |
JUnit assertions should include a message - details... | 90 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 93 |
Local variable could be declared final - details... | 94 |
The String literal "CREATE OR REPLACE someFunction\n" appears 4 times in this file; the first occurrence is on line 97 - details... | 97 |
The String literal "BEGIN somethingElse\n" appears 5 times in this file; the first occurrence is on line 100 - details... | 100 |
The String literal "END somefunction;\n" appears 5 times in this file; the first occurrence is on line 103 - details... | 103 |
Local variable could be declared final - details... | 105 |
Local variable could be declared final - details... | 106 |
Local variable could be declared final - details... | 107 |
JUnit assertions should include a message - details... | 109 |
JUnit assertions should include a message - details... | 110 |
The String literal "CREATE OR REPLACE someFunction\nv_cache_size\nBEGIN something\nBEGIN somethingElse\nEND;\nsome more stuff\nEND somefunction;" appears 4 times in this file; the first occurrence is on line 110 - details... | 110 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 113 |
Local variable could be declared final - details... | 114 |
Local variable could be declared final - details... | 125 |
Local variable could be declared final - details... | 126 |
Local variable could be declared final - details... | 127 |
JUnit assertions should include a message - details... | 129 |
JUnit assertions should include a message - details... | 130 |
JUnit assertions should include a message - details... | 131 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 134 |
Local variable could be declared final - details... | 135 |
Local variable could be declared final - details... | 155 |
Local variable could be declared final - details... | 156 |
Local variable could be declared final - details... | 157 |
JUnit assertions should include a message - details... | 159 |
JUnit assertions should include a message - details... | 160 |
JUnit assertions should include a message - details... | 161 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 164 |
Local variable could be declared final - details... | 165 |
Local variable could be declared final - details... | 194 |
Local variable could be declared final - details... | 195 |
Local variable could be declared final - details... | 196 |
Local variable could be declared final - details... | 198 |
JUnit assertions should include a message - details... | 199 |
JUnit assertions should include a message - details... | 200 |
JUnit assertions should include a message - details... | 201 |
JUnit assertions should include a message - details... | 202 |
JUnit assertions should include a message - details... | 203 |
JUnit assertions should include a message - details... | 204 |
JUnit assertions should include a message - details... | 205 |
JUnit assertions should include a message - details... | 206 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 209 |
Local variable could be declared final - details... | 210 |
Local variable could be declared final - details... | 222 |
Local variable could be declared final - details... | 223 |
Local variable could be declared final - details... | 224 |
JUnit assertions should include a message - details... | 226 |
JUnit assertions should include a message - details... | 227 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 13 |
Each class should declare at least one constructor - details... | 18 |
Parameter 'resource' is not assigned and could be declared final - details... | 20 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 28 |
Private field 'resourcesRun' could be made final; it is only initialized in the declaration or constructor. - details... | 28 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 17 |
Each class should declare at least one constructor - details... | 21 |
Avoid unused private fields such as 'SEPARATORCHAR' - details... | 22 |
JUnit assertions should include a message - details... | 25 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 28 |
Local variable could be declared final - details... | 29 |
Local variable could be declared final - details... | 31 |
Local variable could be declared final - details... | 32 |
Local variable could be declared final - details... | 33 |
Local variable could be declared final - details... | 34 |
JUnit assertions should include a message - details... | 38 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 42 |
Local variable could be declared final - details... | 43 |
Local variable could be declared final - details... | 45 |
Local variable could be declared final - details... | 46 |
Local variable could be declared final - details... | 47 |
Local variable could be declared final - details... | 48 |
Avoid excessively long variable names like ldapDeploymentRunner - details... | 50 |
Local variable could be declared final - details... | 50 |
Local variable could be declared final - details... | 52 |
Local variable could be declared final - details... | 53 |
Local variable could be declared final - details... | 56 |
JUnit assertions should include a message - details... | 57 |
JUnit assertions should include a message - details... | 58 |
JUnit assertions should include a message - details... | 59 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 13 |
No need to import a type that's in the same package - details... | 14 |
No need to import a type that's in the same package - details... | 15 |
Each class should declare at least one constructor - details... | 17 |
Local variable could be declared final - details... | 20 |
Local variable could be declared final - details... | 21 |
JUnit assertions should include a message - details... | 22 |
Local variable could be declared final - details... | 23 |
JUnit assertions should include a message - details... | 24 |
Local variable could be declared final - details... | 28 |
Local variable could be declared final - details... | 29 |
JUnit assertions should include a message - details... | 30 |
JUnit assertions should include a message - details... | 31 |
JUnit assertions should include a message - details... | 32 |
JUnit assertions should include a message - details... | 33 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 14 |
No need to import a type that's in the same package - details... | 15 |
No need to import a type that's in the same package - details... | 16 |
Each class should declare at least one constructor - details... | 18 |
JUnit assertions should include a message - details... | 22 |
JUnit assertions should include a message - details... | 24 |
Local variable could be declared final - details... | 28 |
JUnit assertions should include a message - details... | 29 |
JUnit assertions should include a message - details... | 30 |
JUnit assertions should include a message - details... | 31 |
JUnit assertions should include a message - details... | 32 |
Local variable could be declared final - details... | 36 |
JUnit assertions should include a message - details... | 37 |
JUnit assertions should include a message - details... | 38 |
JUnit assertions should include a message - details... | 39 |
JUnit assertions should include a message - details... | 40 |
Local variable could be declared final - details... | 44 |
JUnit assertions should include a message - details... | 45 |
JUnit assertions should include a message - details... | 46 |
JUnit assertions should include a message - details... | 47 |
Local variable could be declared final - details... | 51 |
Local variable could be declared final - details... | 52 |
JUnit assertions should include a message - details... | 58 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 11 |
Assigning an Object to null is a code smell. Consider refactoring. - details... | 26 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 29 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 30 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 11 |
No need to import a type that's in the same package - details... | 12 |
Parameter 'resource' is not assigned and could be declared final - details... | 25 |
Parameter 'path' is not assigned and could be declared final - details... | 29 |
Parameter 'resource' is not assigned and could be declared final - details... | 29 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 33 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 10 |
Each class should declare at least one constructor - details... | 12 |
Parameter 'script' is not assigned and could be declared final - details... | 13 |
Parameter 'time' is not assigned and could be declared final - details... | 13 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 17 |
Parameter 'group' is not assigned and could be declared final - details... | 17 |
Parameter 'time' is not assigned and could be declared final - details... | 17 |
Avoid variables with short names like e - details... | 21 |
Parameter 'e' is not assigned and could be declared final - details... | 21 |
Parameter 'group' is not assigned and could be declared final - details... | 21 |
Parameter 'script' is not assigned and could be declared final - details... | 21 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 33 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 34 |
Found non-transient, non-static member. Please mark as transient or provide accessors. - details... | 35 |
Perhaps 'groupsExecuted' could be replaced by a local variable. - details... | 35 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 25 |
Each class should declare at least one constructor - details... | 31 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 33 |
Local variable could be declared final - details... | 34 |
Local variable could be declared final - details... | 35 |
Local variable could be declared final - details... | 36 |
Local variable could be declared final - details... | 37 |
JUnit assertions should include a message - details... | 38 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 41 |
Local variable could be declared final - details... | 42 |
Local variable could be declared final - details... | 43 |
Local variable could be declared final - details... | 44 |
Local variable could be declared final - details... | 45 |
JUnit assertions should include a message - details... | 46 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 49 |
Local variable could be declared final - details... | 50 |
Local variable could be declared final - details... | 51 |
Local variable could be declared final - details... | 52 |
JUnit assertions should include a message - details... | 53 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 23 |
No need to import a type that's in the same package - details... | 24 |
Each class should declare at least one constructor - details... | 32 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 34 |
Local variable could be declared final - details... | 35 |
Local variable could be declared final - details... | 36 |
Local variable could be declared final - details... | 37 |
JUnit assertions should include a message - details... | 38 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 41 |
Local variable could be declared final - details... | 42 |
Local variable could be declared final - details... | 43 |
JUnit assertions should include a message - details... | 45 |
JUnit assertions should include a message - details... | 46 |
JUnit assertions should include a message - details... | 47 |
JUnit assertions should include a message - details... | 48 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 51 |
Local variable could be declared final - details... | 52 |
Local variable could be declared final - details... | 53 |
JUnit assertions should include a message - details... | 55 |
JUnit assertions should include a message - details... | 57 |
Use assertNull(x) instead of assertTrue(x==null), or assertNotNull(x) vs assertFalse(x==null) - details... | 57 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 60 |
Local variable could be declared final - details... | 61 |
Local variable could be declared final - details... | 62 |
Local variable could be declared final - details... | 63 |
JUnit assertions should include a message - details... | 64 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 67 |
Local variable could be declared final - details... | 68 |
Local variable could be declared final - details... | 69 |
Local variable could be declared final - details... | 70 |
JUnit assertions should include a message - details... | 71 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 74 |
Local variable could be declared final - details... | 75 |
Local variable could be declared final - details... | 76 |
Local variable could be declared final - details... | 77 |
JUnit assertions should include a message - details... | 78 |
The String literal "foo" appears 12 times in this file; the first occurrence is on line 78 - details... | 78 |
JUnit assertions should include a message - details... | 79 |
The String literal "bar" appears 6 times in this file; the first occurrence is on line 79 - details... | 79 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 82 |
Local variable could be declared final - details... | 83 |
Local variable could be declared final - details... | 84 |
Local variable could be declared final - details... | 85 |
JUnit assertions should include a message - details... | 86 |
JUnit assertions should include a message - details... | 87 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 90 |
Local variable could be declared final - details... | 91 |
Local variable could be declared final - details... | 92 |
Local variable could be declared final - details... | 93 |
JUnit assertions should include a message - details... | 94 |
JUnit assertions should include a message - details... | 95 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 98 |
Local variable could be declared final - details... | 99 |
Local variable could be declared final - details... | 100 |
Local variable could be declared final - details... | 101 |
JUnit assertions should include a message - details... | 102 |
JUnit assertions should include a message - details... | 103 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 106 |
Local variable could be declared final - details... | 107 |
Local variable could be declared final - details... | 108 |
Local variable could be declared final - details... | 109 |
JUnit assertions should include a message - details... | 110 |
JUnit assertions should include a message - details... | 111 |
JUnit assertions should include a message - details... | 112 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 115 |
Local variable could be declared final - details... | 116 |
Local variable could be declared final - details... | 117 |
Local variable could be declared final - details... | 118 |
JUnit assertions should include a message - details... | 119 |
JUnit assertions should include a message - details... | 120 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 123 |
Local variable could be declared final - details... | 124 |
Local variable could be declared final - details... | 125 |
Local variable could be declared final - details... | 126 |
JUnit assertions should include a message - details... | 127 |
JUnit assertions should include a message - details... | 128 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 131 |
Local variable could be declared final - details... | 132 |
Local variable could be declared final - details... | 133 |
Local variable could be declared final - details... | 134 |
JUnit assertions should include a message - details... | 135 |
JUnit assertions should include a message - details... | 136 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 139 |
Local variable could be declared final - details... | 141 |
Local variable could be declared final - details... | 142 |
Local variable could be declared final - details... | 143 |
JUnit assertions should include a message - details... | 144 |
JUnit assertions should include a message - details... | 145 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 148 |
Local variable could be declared final - details... | 150 |
Local variable could be declared final - details... | 151 |
Local variable could be declared final - details... | 152 |
JUnit assertions should include a message - details... | 153 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 156 |
Local variable could be declared final - details... | 158 |
Local variable could be declared final - details... | 159 |
Local variable could be declared final - details... | 160 |
JUnit assertions should include a message - details... | 161 |
JUnit assertions should include a message - details... | 162 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 165 |
Local variable could be declared final - details... | 167 |
Local variable could be declared final - details... | 168 |
Local variable could be declared final - details... | 169 |
JUnit assertions should include a message - details... | 170 |
JUnit assertions should include a message - details... | 171 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 174 |
Local variable could be declared final - details... | 175 |
Local variable could be declared final - details... | 176 |
Local variable could be declared final - details... | 177 |
JUnit assertions should include a message - details... | 178 |
JUnit assertions should include a message - details... | 179 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 182 |
Local variable could be declared final - details... | 183 |
Local variable could be declared final - details... | 184 |
Local variable could be declared final - details... | 185 |
JUnit assertions should include a message - details... | 186 |
JUnit assertions should include a message - details... | 187 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 190 |
Local variable could be declared final - details... | 191 |
Local variable could be declared final - details... | 192 |
Local variable could be declared final - details... | 193 |
JUnit assertions should include a message - details... | 194 |
JUnit assertions should include a message - details... | 195 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 198 |
Local variable could be declared final - details... | 199 |
Local variable could be declared final - details... | 200 |
Local variable could be declared final - details... | 201 |
JUnit assertions should include a message - details... | 202 |
JUnit assertions should include a message - details... | 203 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 206 |
Local variable could be declared final - details... | 207 |
Local variable could be declared final - details... | 208 |
Local variable could be declared final - details... | 209 |
JUnit assertions should include a message - details... | 210 |
JUnit assertions should include a message - details... | 211 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 214 |
Local variable could be declared final - details... | 215 |
Local variable could be declared final - details... | 216 |
JUnit assertions should include a message - details... | 218 |
JUnit assertions should include a message - details... | 219 |
JUnit assertions should include a message - details... | 221 |
JUnit assertions should include a message - details... | 222 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 225 |
Local variable could be declared final - details... | 226 |
Local variable could be declared final - details... | 227 |
JUnit assertions should include a message - details... | 232 |
JUnit assertions should include a message - details... | 233 |
JUnit assertions should include a message - details... | 234 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 238 |
Local variable could be declared final - details... | 239 |
Local variable could be declared final - details... | 240 |
JUnit assertions should include a message - details... | 245 |
JUnit assertions should include a message - details... | 246 |
JUnit assertions should include a message - details... | 247 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 251 |
Local variable could be declared final - details... | 252 |
Local variable could be declared final - details... | 253 |
JUnit assertions should include a message - details... | 258 |
JUnit assertions should include a message - details... | 259 |
JUnit assertions should include a message - details... | 260 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 264 |
Local variable could be declared final - details... | 265 |
Local variable could be declared final - details... | 266 |
Local variable could be declared final - details... | 267 |
JUnit assertions should include a message - details... | 268 |
JUnit assertions should include a message - details... | 269 |
JUnit assertions should include a message - details... | 270 |
JUnit assertions should include a message - details... | 271 |
JUnit assertions should include a message - details... | 272 |
JUnit assertions should include a message - details... | 273 |
JUnit assertions should include a message - details... | 274 |
JUnit assertions should include a message - details... | 275 |
JUnit assertions should include a message - details... | 276 |
JUnit assertions should include a message - details... | 277 |
JUnit assertions should include a message - details... | 278 |
JUnit assertions should include a message - details... | 279 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 282 |
Local variable could be declared final - details... | 283 |
Local variable could be declared final - details... | 284 |
JUnit assertions should include a message - details... | 287 |
JUnit assertions should include a message - details... | 288 |
JUnit assertions should include a message - details... | 291 |
JUnit assertions should include a message - details... | 292 |
JUnit assertions should include a message - details... | 295 |
JUnit assertions should include a message - details... | 296 |
Local variable could be declared final - details... | 300 |
Local variable could be declared final - details... | 301 |
JUnit assertions should include a message - details... | 302 |
JUnit assertions should include a message - details... | 303 |
JUnit assertions should include a message - details... | 304 |
JUnit assertions should include a message - details... | 305 |
JUnit assertions should include a message - details... | 306 |
Avoid empty catch blocks - details... | 310 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 22 |
Each class should declare at least one constructor - details... | 30 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 32 |
Local variable could be declared final - details... | 33 |
Local variable could be declared final - details... | 34 |
Local variable could be declared final - details... | 35 |
JUnit assertions should include a message - details... | 37 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 40 |
Local variable could be declared final - details... | 41 |
Local variable could be declared final - details... | 42 |
Local variable could be declared final - details... | 43 |
The String literal "foo" appears 8 times in this file; the first occurrence is on line 43 - details... | 43 |
JUnit assertions should include a message - details... | 45 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 48 |
Local variable could be declared final - details... | 49 |
Local variable could be declared final - details... | 50 |
Local variable could be declared final - details... | 51 |
JUnit assertions should include a message - details... | 53 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 56 |
Local variable could be declared final - details... | 57 |
Local variable could be declared final - details... | 58 |
Local variable could be declared final - details... | 59 |
JUnit assertions should include a message - details... | 61 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 64 |
Local variable could be declared final - details... | 65 |
Local variable could be declared final - details... | 66 |
Local variable could be declared final - details... | 67 |
JUnit assertions should include a message - details... | 69 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 72 |
Local variable could be declared final - details... | 73 |
Local variable could be declared final - details... | 74 |
Local variable could be declared final - details... | 75 |
JUnit assertions should include a message - details... | 77 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 80 |
Local variable could be declared final - details... | 81 |
Local variable could be declared final - details... | 82 |
Local variable could be declared final - details... | 83 |
JUnit assertions should include a message - details... | 85 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 88 |
Local variable could be declared final - details... | 89 |
Local variable could be declared final - details... | 90 |
Local variable could be declared final - details... | 91 |
JUnit assertions should include a message - details... | 93 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 96 |
Local variable could be declared final - details... | 97 |
Local variable could be declared final - details... | 98 |
Local variable could be declared final - details... | 99 |
JUnit assertions should include a message - details... | 101 |
Violation | Line |
---|---|
No need to import a type that's in the same package - details... | 23 |
Each class should declare at least one constructor - details... | 31 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 33 |
Local variable could be declared final - details... | 34 |
Local variable could be declared final - details... | 35 |
Local variable could be declared final - details... | 36 |
JUnit assertions should include a message - details... | 37 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 40 |
Local variable could be declared final - details... | 41 |
The String literal "field1" appears 5 times in this file; the first occurrence is on line 41 - details... | 41 |
Local variable could be declared final - details... | 42 |
Local variable could be declared final - details... | 43 |
JUnit assertions should include a message - details... | 44 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 47 |
Local variable could be declared final - details... | 48 |
Local variable could be declared final - details... | 49 |
Local variable could be declared final - details... | 50 |
JUnit assertions should include a message - details... | 51 |
JUnit assertions should include a message - details... | 52 |
The String literal "value1" appears 4 times in this file; the first occurrence is on line 52 - details... | 52 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 55 |
Local variable could be declared final - details... | 56 |
Local variable could be declared final - details... | 57 |
Local variable could be declared final - details... | 58 |
JUnit assertions should include a message - details... | 59 |
JUnit assertions should include a message - details... | 60 |
JUnit assertions should include a message - details... | 61 |
The String literal "field2" appears 4 times in this file; the first occurrence is on line 61 - details... | 61 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 64 |
Local variable could be declared final - details... | 65 |
Local variable could be declared final - details... | 66 |
JUnit assertions should include a message - details... | 68 |
JUnit assertions should include a message - details... | 69 |
JUnit assertions should include a message - details... | 70 |
JUnit assertions should include a message - details... | 72 |
JUnit assertions should include a message - details... | 73 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 76 |
Local variable could be declared final - details... | 77 |
Local variable could be declared final - details... | 78 |
Local variable could be declared final - details... | 79 |
JUnit assertions should include a message - details... | 80 |
JUnit assertions should include a message - details... | 81 |
JUnit assertions should include a message - details... | 82 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 85 |
Local variable could be declared final - details... | 86 |
Local variable could be declared final - details... | 87 |
Avoid unused local variables such as 'content' - details... | 89 |
Local variable could be declared final - details... | 89 |
Avoid empty catch blocks - details... | 91 |
A signature (constructor or method) shouldn't have Exception in throws declaration - details... | 96 |
Local variable could be declared final - details... | 97 |
Local variable could be declared final - details... | 98 |
Avoid unused local variables such as 'content' - details... | 100 |
Local variable could be declared final - details... | 100 |
Avoid empty catch blocks - details... | 102 |